Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(release): eliminate bypassing of branch protection #249

Merged
merged 2 commits into from
Sep 15, 2023
Merged

ci(release): eliminate bypassing of branch protection #249

merged 2 commits into from
Sep 15, 2023

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Sep 14, 2023 •
edited
Loading

The workflow commits to the main branch and the branch protection configured in the GitHub repository prevents this for all users.

Previously, the protection was temporarily bypassed and the user performing the commit required administrator permissions (due to the configuration of the branch protection).

Now protection is done using GitHub branch ruleset, and there's no need to bypass protection. In this way, workflow can be simplified.

Notes

The settings have already been updated

  • ruleset replaces branch protection: https://github.com/process-analytics/bpmn-visualization-R/rules (publicly visible)
    repository
  • permissions of the user performing the Git operations in the repository has been downgraded. ⚠️ IMPORTANT: this PR must then be merged prior doing the next release. The workflow currently in the main branch requires this user to have more permissions. If executed, it will fail.

This configuration is already used in the bv-experimental-add-ons repository:

image
Ruleset definition view as an non authenticated user

@tbouffard
ci(release): eliminate bypassing of branch protection
eff509c 
The workflow commits to the main branch and the branch protection configured in the GitHub repository prevents this for
all users.
Previously, the protection was temporarily bypassed and the user performing the commit required administrator permissions
(due to the configuration of the branch protection).
Now protection is done using GitHub branch ruleset, and there's no need to bypass protection. In this way, workflow can
be simplified.
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Sep 14, 2023
@tbouffard tbouffard marked this pull request as ready for review September 14, 2023 07:33
@tbouffard tbouffard requested a review from csouchet September 14, 2023 07:33
@csouchet csouchet enabled auto-merge (squash) September 15, 2023 08:11
@csouchet csouchet merged commit ffeb4e6 into main Sep 15, 2023
@csouchet csouchet deleted the ci/release_no_need_for_admin_permissions branch September 15, 2023 08:11
This was referenced Sep 18, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csouchet csouchet csouchet approved these changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbouffard @csouchet