Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(release): eliminate bypassing of branch protection #2863

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Sep 18, 2023

The workflow commits to the main branch and the branch protection configured in the GitHub repository prevents this for all users.

Previously, the protection was temporarily bypassed and the user performing the commit required administrator permissions (due to the configuration of the branch protection).

Now protection is done using GitHub branch ruleset, and there's no need to bypass protection. In this way, workflow can be simplified.

Notes

The settings have already been updated

  • rulesets replaces branch and tag protection: https://github.com/process-analytics/bpmn-visualization-js/rules (publicly visible)
    repository
  • permissions of the user performing the Git operations in the repository has been downgraded. ⚠️ IMPORTANT: this PR must then be merged prior doing the next release. The workflow currently in the main branch requires this user to have more permissions. If executed, it will fail.

This configuration is already used in the following repositories

Ruleset definition view for user with read-only access to the repository

image

default branch tags
image image

The workflow commits to the main branch and the branch protection configured in the GitHub repository prevents this for all users.

Previously, the protection was temporarily bypassed and the user performing the commit required administrator permissions (due to the configuration of the branch protection).

Now protection is done using GitHub branch ruleset, and there's no need to bypass protection. In this way, workflow can be simplified.
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Sep 18, 2023
@tbouffard tbouffard requested a review from csouchet September 18, 2023 15:28
@tbouffard tbouffard marked this pull request as ready for review September 18, 2023 15:28
@tbouffard tbouffard merged commit fb1cf99 into master Sep 19, 2023
2 checks passed
@tbouffard tbouffard deleted the ci/release_no_need_for_admin_permissions branch September 19, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants