refactor: directly override shape.createSvgCanvas
#3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
depends on another PR ⚠️
tbouffard
commented
Feb 22, 2024
Previously, this was done by modifying the shape prototype. The new implementation limits side effects on application that use mxGraph directly, and don't modify code we don't own. The change is validated by integration tests that check that the bpmn-id and the CSS classes in the DOM are correctly set on both shapes/edges and labels. This is also validated with the elements-identification.html demo. The CSS class is correctly applied to the label.
tbouffard
force-pushed
the
refactor/no_shape.createSvgCanvas_prototype_override
branch
from
4559246
to
fd9a1ec
Compare
tbouffard
removed
the
depends on another PR ⚠️
|
♻️ PR Preview fd9a1ec has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview fd9a1ec has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
csouchet
approved these changes
Mar 1, 2024
tbouffard
deleted the
refactor/no_shape.createSvgCanvas_prototype_override
branch
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, this was done by modifying the shape prototype.
The new implementation limits side effects on application that use mxGraph directly, and don't modify code we don't own.
Testing
The change is validated by integration tests that check that the bpmn-id and the CSS classes in the DOM are correctly
set on both shapes/edges and labels.
This is also validated with the elements-identification.html demo. The CSS class is correctly applied to the label.