Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: directly override shape.createSvgCanvas #3043

Merged

Commits on Mar 1, 2024

  1. refactor: directly override shape.createSvgCanvas

    Previously, this was done by modifying the shape prototype.
    The new implementation limits side effects on application that use mxGraph directly, and don't modify code we don't own.
    
    The change is validated by integration tests that check that the bpmn-id and the CSS classes in the DOM are correctly
    set on both shapes/edges and labels.
    This is also validated with the elements-identification.html demo. The CSS class is correctly applied to the label.
    tbouffard committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    fd9a1ec View commit details
    Browse the repository at this point in the history