Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a global Cargo workspace #613

Merged
merged 5 commits into from
Feb 17, 2020
Merged

Create a global Cargo workspace #613

merged 5 commits into from
Feb 17, 2020

Conversation

ipetr0v
Copy link
Contributor

@ipetr0v ipetr0v commented Feb 16, 2020 •
edited
Loading

This change:

  • Creates a new single Cargo workspace for the entire repository
  • Removes old Cargo workspaces:
    • examples/Cargo.toml
    • oak/server/rust/Cargo.toml
    • sdk/rust/Cargo.toml
    • third_party/grpc-rust/Cargo.toml

Fixes #534

Checklist

  • Pull request affects core Oak functionality (e.g. runtime, SDK, ABI)
    • I have written tests that cover the code changes.
    • I have checked that these tests are run by Cloudbuild
    • I have updated documentation accordingly.
    • I have raised an issue to
      cover any TODOs and/or unfinished work.
  • Pull request includes prototype/experimental work that is under
    construction.

@ipetr0v ipetr0v marked this pull request as ready for review February 16, 2020 16:51
tiziano88
tiziano88 approved these changes Feb 17, 2020
View reviewed changes
Cargo.toml Show resolved Hide resolved
scripts/check_formatting Outdated Show resolved Hide resolved
scripts/run_tests Outdated Show resolved Hide resolved
@ipetr0v ipetr0v changed the title Delete old Cargo workspaces Create a global Cargo workspace Feb 17, 2020
@ipetr0v ipetr0v merged commit 9d7186e into project-oak:master Feb 17, 2020
@ipetr0v ipetr0v deleted the single_workspace branch February 17, 2020 14:25
tiziano88 added a commit to tiziano88/oak that referenced this pull request Feb 17, 2020
@tiziano88
Fix build_gh_pages script
4f342c1 
After project-oak#613 there is now a single Cargo workspace, so the script needs to
be changed to deal with that.

Note that this now also generates docs for example crates.

Ref. project-oak#534
@tiziano88 tiziano88 mentioned this pull request Feb 17, 2020
Merged
6 tasks
tiziano88 added a commit that referenced this pull request Feb 18, 2020
@tiziano88
Fix build_gh_pages script (#616)
35d77d0 
After #613 there is now a single Cargo workspace, so the script needs to
be changed to deal with that.

Note that this now also generates docs for example crates.

Ref. #534
@daviddrysdale daviddrysdale mentioned this pull request Mar 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiziano88 tiziano88 tiziano88 approved these changes

@daviddrysdale daviddrysdale Awaiting requested review from daviddrysdale

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single Cargo workspace for the entire repository
3 participants
@ipetr0v @tiziano88 @googlebot