Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build_gh_pages script #616

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Fix build_gh_pages script #616

merged 1 commit into from
Feb 18, 2020

Conversation

tiziano88
Copy link
Collaborator

After #613 there is now a single Cargo workspace, so the script needs to
be changed to deal with that.

Note that this now also generates docs for example crates.

Ref. #534

Checklist

  • Pull request affects core Oak functionality (e.g. runtime, SDK, ABI)
    • I have written tests that cover the code changes.
    • I have checked that these tests are run by Cloudbuild
    • I have updated documentation accordingly.
    • I have raised an issue to
      cover any TODOs and/or unfinished work.
  • Pull request includes prototype/experimental work that is under
    construction.

@tiziano88
Fix build_gh_pages script
4f342c1 
After project-oak#613 there is now a single Cargo workspace, so the script needs to
be changed to deal with that.

Note that this now also generates docs for example crates.

Ref. project-oak#534
daviddrysdale
daviddrysdale approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@daviddrysdale daviddrysdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to change every link that references the doc pages once the first commit with the new directory layout goes into gh-pages, but that's presumably a separate PR.

@tiziano88 tiziano88 merged commit 35d77d0 into project-oak:master Feb 18, 2020
@tiziano88 tiziano88 deleted the tzn_gh_pages_fix branch February 18, 2020 08:50
tiziano88 added a commit to tiziano88/oak that referenced this pull request Feb 18, 2020
@tiziano88
Fix links to Rust documentation
f7a6d7a 
After project-oak#616
@tiziano88 tiziano88 mentioned this pull request Feb 18, 2020
Merged
tiziano88 added a commit that referenced this pull request Feb 18, 2020
@tiziano88
Fix links to Rust documentation (#618)
defaa7e 
After #616
@daviddrysdale
Copy link
Contributor

(BTWs, I now think that including docs for example and experimental crates isn't helpful – it's hard to pick out the useful SDK documentation from the morass of undocumented example crates.)

@daviddrysdale daviddrysdale mentioned this pull request Mar 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddrysdale daviddrysdale daviddrysdale approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiziano88 @daviddrysdale @googlebot