This repository has been archived by the owner on Jan 19, 2018. It is now read-only.

Should the Docker provider remove the deployed containers on failure? #421

Open

cdrage opened this issue Nov 24, 2015 · 7 comments

Assignees

Labels

work in progress

Member

cdrage commented Nov 24, 2015

When deploying using the Docker provider, you may run into the issues of a container already being deployed on a current port.

Unfortunatley, even if it fails, the containers you deployed up until that point are lingering on.

Should the Docker provider go through all the deployed containers thus far and remove them? Or is this too dangerous?

Contributor

dustymabe commented Nov 24, 2015

we will be adding some tooling around "removing" containers sometime soon as part of #308 .. Let's revisit after we have the full lifecyle in place..

We may decide that if a part of it fails then it is reasonable to have the user do a clean or equivalent before they start to run it again.

Contributor

rtnpro commented Nov 25, 2015

It's a generic problem, and not just for Docker. As we had already discussed in the past, IIRC, deployments should be atomic. If the deployment of a component fails, we should rollback the deployment of any other deployed component.

rtnpro added the GA label

Contributor

dustymabe commented Nov 25, 2015

@cdrage this is also #319

rtnpro added this to the CDK 2 GA milestone

rtnpro removed the GA label

dustymabe assigned cdrage

Contributor

dustymabe commented Nov 25, 2015

Ok let's get it in for GA then

dustymabe mentioned this issue

Remove running components if one component fails #319

Open

rtnpro assigned rtnpro and unassigned cdrage

Contributor

rtnpro commented Dec 15, 2015

This issue should be renamed to Atomic deployments, I think :)

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Implement atomic deployments for Nulecule application. Fixes projecta…

cfd0321

…tomic#421

When there's an error during running a Nulecule application,
rollback the changes made by stopping the application.

rtnpro added the work in progress label

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Implement atomic deployments for Nulecule application. Fixes projecta…

3ef9939

…tomic#421

When there's an error during running a Nulecule application,
rollback the changes made by stopping the application.

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Implement atomic deployments for Nulecule application. Fixes projecta…

7db3cca

…tomic#421

When there's an error during running a Nulecule application,
rollback the changes made by stopping the application.

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Fixed unittests for refactored NuleculeComponent.stop() signature

445607b

Fixes projectatomic#421

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Implement atomic deployments for Nulecule application. Fixes projecta…

ef3c3fa

…tomic#421

When there's an error during running a Nulecule application,
rollback the changes made by stopping the application.

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Fixed unittests for refactored NuleculeComponent.stop() signature

288bfc7

Fixes projectatomic#421

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Implement atomic deployments for openshift provider. Fixes projectato…

3e85bff

…mic#421

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Implement atomic deployments for Nulecule application. Fixes projecta…

0227a78

…tomic#421

When there's an error during running a Nulecule application,
rollback the changes made by stopping the application.

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Fixed unittests for refactored NuleculeComponent.stop() signature

e22769f

Fixes projectatomic#421

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Implement atomic deployments for openshift provider. Fixes projectato…

3078b30

…mic#421

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Raise an error when rolling back an application deployment. Fixes pro…

0ed4f1c

…jectatomic#421

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Raise an error when rolling back an application deployment. Fixes pro…

629a96d

…jectatomic#421

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Implement atomic deployments for Nulecule application. Fixes projecta…

98c7928

…tomic#421

When there's an error during running a Nulecule application,
rollback the changes made by stopping the application.

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Fixed unittests for refactored NuleculeComponent.stop() signature

6f59120

Fixes projectatomic#421

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Implement atomic deployments for openshift provider. Fixes projectato…

a462faa

…mic#421

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Raise an error when rolling back an application deployment. Fixes pro…

68c2303

…jectatomic#421

kadel removed the blocker label

kadel added blocker and removed blocker labels

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Implement atomic deployments for Nulecule application. Fixes projecta…

deeaec6

…tomic#421

When there's an error during running a Nulecule application,
rollback the changes made by stopping the application.

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Fixed unittests for refactored NuleculeComponent.stop() signature

0afcf1f

Fixes projectatomic#421

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Implement atomic deployments for openshift provider. Fixes projectato…

1153b29

…mic#421

rtnpro added a commit to rtnpro/atomicapp that referenced this issue


          Raise an error when rolling back an application deployment. Fixes pro…

2ffb11c

…jectatomic#421

Contributor

rtnpro commented Feb 9, 2016

Fixed in #456

rtnpro modified the milestone: CDK 2 GA

Contributor

dustymabe commented Feb 11, 2016

Removing the blocker label from this. We won't be doing this before GA for several reasons.

Implement atomic deployments for Nulecule application. Fixes #421 #456 is a risky change that is a "nice to have"
There are issues with removing a docker container from within atomicapp prior to docker 1.9

dustymabe removed the blocker label

dustymabe mentioned this issue

[WIP] k8s cmd to api #653

Closed

4 tasks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.