Implement atomic deployments for Nulecule application. Fixes projecta…

…tomic#421

When there's an error during running a Nulecule application,
rollback the changes made by stopping the application.

atomicapp/nulecule/base.py

@@ -159,22 +159,23 @@ def run(self, provider_key=None, dryrun=False):
         for component in self.components:
             component.run(provider_key, dryrun)
 
-    def stop(self, provider_key=None, dryrun=False):
+    def stop(self, provider_key=None, dryrun=False, ignore_errors=False):
         """
         Stop the Nulecule application.
 
         Args:
             provider_key (str): Provider to use for running Nulecule
                                 application
             dryrun (bool): Do not make changes to host when True
+            ignore_errors (bool): Ignore errors, if any, when True
 
         Returns:
             None
         """
         provider_key, provider = self.get_provider(provider_key, dryrun)
         # stop the Nulecule application
         for component in self.components:
-            component.stop(provider_key, dryrun)
+            component.stop(provider_key, dryrun, ignore_errors)
 
     # TODO: NOT YET IMPLEMENTED
     def uninstall(self):
@@ -292,7 +293,7 @@ def run(self, provider_key, dryrun=False):
         provider.init()
         provider.deploy()
 
-    def stop(self, provider_key=None, dryrun=False):
+    def stop(self, provider_key=None, dryrun=False, ignore_errors=False):
         """
         Stop the Nulecule component with the specified provider.
         """
@@ -302,6 +303,7 @@ def stop(self, provider_key=None, dryrun=False):
         provider_key, provider = self.get_provider(provider_key, dryrun)
         provider.artifacts = self.rendered_artifacts.get(provider_key, [])
         provider.init()
+        provider.ignore_errors = ignore_errors
         provider.undeploy()
 
     def load_config(self, config=None, ask=False, skip_asking=False):

atomicapp/nulecule/main.py

@@ -233,7 +233,7 @@ def run(self, cli_provider, answers_output, ask,
 
         self.nulecule.load_config(config=self.nulecule.config, ask=ask)
         self.nulecule.render(cli_provider, dryrun)
-        self.nulecule.run(cli_provider, dryrun)
+
         runtime_answers = self._get_runtime_answers(
             self.nulecule.config, cli_provider)
         self._write_answers(
@@ -243,12 +243,21 @@ def run(self, cli_provider, answers_output, ask,
             self._write_answers(answers_output, runtime_answers,
                                 self.answers_format)
 
-    def stop(self, cli_provider, **kwargs):
+        try:
+            self.nulecule.run(cli_provider, dryrun)
+        except Exception as e:
+            logger.error('Application run error: %s' % e)
+            logger.debug('Nulecule run error: %s' % e, exc_info=True)
+            logger.info('Rolling back changes')
+            self.stop(cli_provider, ignore_errors=True, **kwargs)
+
+    def stop(self, cli_provider, ignore_errors=False, **kwargs):
         """
         Stops a running Nulecule application.
 
         Args:
             cli_provider (str): Provider running the Nulecule application
+            ignore_errors (bool): Ignore errors, if any, when True
             kwargs (dict): Extra keyword arguments
         """
         # For stop we use the generated answer file from the run
@@ -260,7 +269,7 @@ def stop(self, cli_provider, **kwargs):
             self.app_path, config=self.answers, dryrun=dryrun)
         self.nulecule.load_config(config=self.answers)
         self.nulecule.render(cli_provider, dryrun=dryrun)
-        self.nulecule.stop(cli_provider, dryrun)
+        self.nulecule.stop(cli_provider, dryrun, ignore_errors)
 
     def uninstall(self):
         # For future use

atomicapp/plugin.py

@@ -53,6 +53,7 @@ def __init__(self, config, path, dryrun):
         self.config = config
         self.path = path
         self.dryrun = dryrun
+        self.ignore_errors = False
         if Utils.getRoot() == HOST_DIR:
             self.container = True
 

atomicapp/providers/docker.py

@@ -138,4 +138,8 @@ def undeploy(self):
                 if self.dryrun:
                     logger.info("DRY-RUN: STOPPING CONTAINER %s", " ".join(cmd))
                 else:
-                    subprocess.check_call(cmd)
+                    try:
+                        subprocess.check_call(cmd)
+                    except Exception as e:
+                        if not self.ignore_errors:
+                            raise e

atomicapp/providers/kubernetes.py

@@ -107,8 +107,12 @@ def _call(self, cmd):
         if self.dryrun:
             logger.info("DRY-RUN: %s", " ".join(cmd))
         else:
-            ec, stdout, stderr = Utils.run_cmd(cmd, checkexitcode=True)
-            return stdout
+            try:
+                ec, stdout, stderr = Utils.run_cmd(cmd, checkexitcode=True)
+                return stdout
+            except Exception as e:
+                if not self.ignore_errors:
+                    raise e
 
     def process_k8s_artifacts(self):
         """Processes Kubernetes manifests files and checks if manifest under