This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Adds Route Selection Validation for Gateway #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danehans
requested review from
sunjayBhatia and
youngnick
and removed request for
a team
This was referenced Mar 16, 2021
skriss
suggested changes
Mar 18, 2021
danehans
force-pushed
the
route_valid
branch
2 times, most recently
from
1592066 to
5eef417
Compare
|
@skriss thanks for the review. Commit |
danehans
commented
Mar 18, 2021
go.mod
Outdated
| sigs.k8s.io/controller-tools v0.4.1 | ||
| sigs.k8s.io/gateway-api v0.2.0 | ||
| ) | ||
|
|
||
| // Remove when https://github.com/projectcontour/contour/pull/3499 is merged. | ||
| replace github.com/projectcontour/contour => github.com/danehans/contour v0.13.0-beta.2.0.20210318163459-9274cd62d96d |
Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
|
/hold until Gateway API implementation plan is resolved. |
|
xref kubernetes-sigs/gateway-api#597 to add validation pkg upstream. |
|
Closing since GatewayClass and Gateway controllers are being migrated to Contour. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #215
Fixes: #234
Signed-off-by: Daneyon Hansen daneyonhansen@gmail.com