Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Validation Package #3499

Closed
wants to merge 1 commit into from
Closed

Conversation

danehans
Copy link
Contributor

Refactors #3477 into a validation pkg that can be used by projectcontour/contour-operator#226 and others.

Signed-off-by: Daneyon Hansen daneyonhansen@gmail.com

@danehans danehans requested a review from a team as a code owner March 18, 2021 16:15
@danehans danehans requested review from stevesloka and sunjayBhatia and removed request for a team March 18, 2021 16:15
@danehans danehans self-assigned this Mar 18, 2021
@danehans danehans added this to the 1.14.0 milestone Mar 18, 2021
@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #3499 (16c0fb3) into main (4c319b6) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 16c0fb3 differs from pull request most recent head 9274cd6. Consider uploading reports for the commit 9274cd6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3499      +/-   ##
==========================================
- Coverage   75.38%   75.35%   -0.03%     
==========================================
  Files          98       98              
  Lines        6614     6606       -8     
==========================================
- Hits         4986     4978       -8     
  Misses       1516     1516              
  Partials      112      112              
Impacted Files Coverage Δ
internal/dag/gatewayapi_processor.go 80.28% <100.00%> (-2.00%) ⬇️

Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
@skriss
Copy link
Member

skriss commented Mar 18, 2021

One option for these validation helpers would be to put them in a new module/repo under projectcontour, with a v0 version, so that we don't have to have compatibility guarantees for now. As soon as they're publicly exported in projectcontour/contour, we're not support to change the API.

I'd like to see some discussion of this vs other approaches for these shared libraries.

@danehans
Copy link
Contributor Author

Closing in favor of adding validation upstream, xref: kubernetes-sigs/gateway-api#487

@danehans danehans closed this Mar 23, 2021
@danehans
Copy link
Contributor Author

xref kubernetes-sigs/gateway-api#597 to add validation pkg upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants