-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to Gateway API v0.5.0-rc1 #4562
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4562 +/- ##
=======================================
Coverage 77.00% 77.00%
=======================================
Files 140 140
Lines 12784 12784
=======================================
Hits 9844 9844
Misses 2684 2684
Partials 256 256
|
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
|
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick read through lgtm so far!
We could merge this now if we want, which would unblock the other 2 PRs that will get Gateway API conformance passing again, but also can wait until v0.5.0 comes out in a week or two - I'm fine either way since the end result will be the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm cool with merging things early to unblock other things on main
, assuming the ga release will be pretty close to this, and will come out before we release a new Contour version
Updates #4560.