Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Gateway API v0.5.0-rc1 #4562

Merged
merged 12 commits into from
Jun 16, 2022
Merged

Conversation

skriss
Copy link
Member

@skriss skriss commented Jun 8, 2022

Updates #4560.

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #4562 (80ce8ce) into main (b0fa15d) will not change coverage.
The diff coverage is 80.95%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4562   +/-   ##
=======================================
  Coverage   77.00%   77.00%           
=======================================
  Files         140      140           
  Lines       12784    12784           
=======================================
  Hits         9844     9844           
  Misses       2684     2684           
  Partials      256      256           
Impacted Files Coverage Δ
internal/status/routeconditions.go 17.72% <0.00%> (ø)
internal/dag/gatewayapi_processor.go 95.44% <91.66%> (ø)
internal/dag/cache.go 94.73% <100.00%> (ø)
internal/gatewayapi/helpers.go 100.00% <100.00%> (ø)

skriss added 10 commits June 15, 2022 01:24
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss
Copy link
Member Author

skriss commented Jun 15, 2022

  • Updated with v0.5.0-rc1
  • backed out the ReferencePolicy -> ReferenceGrant changes (although some of the structs that ReferencePolicy uses have been renamed so I accomodated those) since ReferencePolicy is sticking around for one more release, so I'll do a separate PR to support both for 1 release
  • will also do the migration to v1beta1 resources in a separate PR.
  • will also pin conformance tests to this release, for PR builds, in a separate PR

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Steve Kriss <krisss@vmware.com>
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick read through lgtm so far!

@skriss skriss changed the title [WIP] update to Gateway API v0.5.0 update to Gateway API v0.5.0-rc1 Jun 15, 2022
@skriss
Copy link
Member Author

skriss commented Jun 15, 2022

We could merge this now if we want, which would unblock the other 2 PRs that will get Gateway API conformance passing again, but also can wait until v0.5.0 comes out in a week or two - I'm fine either way since the end result will be the same.

@skriss skriss marked this pull request as ready for review June 15, 2022 21:25
@skriss skriss requested a review from a team as a code owner June 15, 2022 21:25
@skriss skriss requested review from tsaarni and sunjayBhatia and removed request for a team June 15, 2022 21:25
@skriss skriss added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Jun 15, 2022
@skriss skriss requested a review from youngnick June 15, 2022 21:26
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm cool with merging things early to unblock other things on main, assuming the ga release will be pretty close to this, and will come out before we release a new Contour version

@skriss skriss merged commit 485238e into projectcontour:main Jun 16, 2022
@skriss skriss deleted the gw-api-v0.5.0 branch June 16, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants