Gateway API: add support for ReferenceGrant #4580
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4580 +/- ##
==========================================
- Coverage 77.00% 76.82% -0.19%
==========================================
Files 140 140
Lines 12784 12813 +29
==========================================
- Hits 9844 9843 -1
- Misses 2684 2713 +29
- Partials 256 257 +1
|
Adds support for the renamed ReferenceGrant resource while retaining support for ReferencePolicy, to allow for a seamless migration. ReferencePolicy support will be removed in a subsequent release. Updates projectcontour#4555. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
requested review from
tsaarni and
sunjayBhatia
and removed request for
a team
skriss
added
release-note/small
| @@ -1424,7 +1424,7 @@ func TestDAGInsertGatewayAPI(t *testing.T) { | |||
| }, | |||
| ), | |||
| }, | |||
| "HTTPRoute references a backend in a different namespace, no ReferencePolicy": { | |||
| "HTTPRoute references a backend in a different namespace, no ReferenceGrant": { | |||
There was a problem hiding this comment.
I decided to just switch these tests over rather than duplicate them, since the old ones will go away soon, but I can do the former if folks think it's necessary.
There was a problem hiding this comment.
LGTM
just thinking out loud, since referencepolicy/grant is an "allow list" rather than a block list, there can't be really any conflicts between different instances of either, so seems pretty simple to have both working etc. and remove referencepolicy next next (1.23.0) version
Adds support for the renamed ReferenceGrant
resource while retaining support for
ReferencePolicy, to allow for a seamless
migration. ReferencePolicy support will
be removed in a subsequent release.
Updates #4555.
Signed-off-by: Steve Kriss krisss@vmware.com