Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway API: ReferencePolicy -> ReferenceGrant rename #4555

Closed
Tracked by #4738
skriss opened this issue Jun 3, 2022 · 4 comments · Fixed by #4929
Closed
Tracked by #4738

Gateway API: ReferencePolicy -> ReferenceGrant rename #4555

skriss opened this issue Jun 3, 2022 · 4 comments · Fixed by #4929
Assignees
@skriss
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. blocked/needs-gateway-api Categorizes the issue or PR as blocked because it needs changes in Gateway API. kind/feature Categorizes issue or PR as related to a new feature.
Milestone
1.24.0

Comments

@skriss
Copy link
Member

skriss commented Jun 3, 2022

Gateway API is renaming the ReferencePolicy resource to ReferenceGrant. We'll need to update Contour for this.

ref. kubernetes-sigs/gateway-api#1179
@skriss skriss added kind/feature Categorizes issue or PR as related to a new feature. area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. labels Jun 3, 2022
@skriss skriss added this to the 1.22.0 milestone Jun 3, 2022
@skriss skriss mentioned this issue Jun 8, 2022
Closed
@skriss skriss self-assigned this Jun 8, 2022
@skriss skriss mentioned this issue Jun 8, 2022
Merged
@youngnick
Copy link
Member

As of today, ReferencePolicy will be still included in v0.5.0, so it's not super urgent, but we should move before v0.6.0, when it will be removed (and most likely, moved to beta tbh).

skriss added a commit to skriss/contour that referenced this issue Jun 15, 2022
@skriss
Gateway API: add support for ReferenceGrant
807619a 
Adds support for the renamed ReferenceGrant
resource while retaining support for
ReferencePolicy, to allow for a seamless
migration. ReferencePolicy support will
be removed in a subsequent release.

Updates projectcontour#4555.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Jun 15, 2022
Merged
skriss added a commit to skriss/contour that referenced this issue Jun 16, 2022
@skriss
Gateway API: add support for ReferenceGrant
469df35 
Adds support for the renamed ReferenceGrant
resource while retaining support for
ReferencePolicy, to allow for a seamless
migration. ReferencePolicy support will
be removed in a subsequent release.

Updates projectcontour#4555.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit that referenced this issue Jun 16, 2022
@skriss
Gateway API: add support for ReferenceGrant (#4580)
c74c33a 
Adds support for the renamed ReferenceGrant
resource while retaining support for
ReferencePolicy, to allow for a seamless
migration. ReferencePolicy support will
be removed in a subsequent release.

Updates #4555.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss
Copy link
Member Author

skriss commented Jun 16, 2022 •
edited
Loading

Still to do: drop ReferencePolicy when we upgrade to v0.6.0. Moving to 1.23 to close out.

@skriss skriss modified the milestones: 1.22.0, 1.23.0 Jun 16, 2022
@skriss skriss added this to Contour Jul 25, 2022
@skriss skriss moved this to Todo in Contour Jul 25, 2022
@skriss skriss added the blocked/needs-gateway-api Categorizes the issue or PR as blocked because it needs changes in Gateway API. label Sep 14, 2022
@skriss skriss modified the milestones: 1.23.0, 1.24.0 Sep 20, 2022
@skriss
Copy link
Member Author

skriss commented Sep 20, 2022

Moving to 1.24 since it's unlikely we'll get Gateway API v0.6 into 1.23.

@skriss skriss removed their assignment Sep 20, 2022
@skriss skriss mentioned this issue Sep 20, 2022
Closed
3 tasks
@skriss skriss self-assigned this Nov 2, 2022
@skriss skriss moved this from Todo to In Progress in Contour Nov 2, 2022
skriss added a commit to skriss/contour that referenced this issue Nov 2, 2022
@skriss
drop support for ReferencePolicy
6e2e191 
Drops support for ReferencePolicy, which
has been replaced by ReferenceGrant in
Gateway API.

Updates projectcontour#4555.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Nov 2, 2022
Merged
@skriss
Copy link
Member Author

skriss commented Nov 2, 2022

@sunjayBhatia sunjayBhatia mentioned this issue Nov 7, 2022
Closed
skriss added a commit that referenced this issue Nov 7, 2022
@skriss
drop support for ReferencePolicy (#4830)
6e469c9 
Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

Updates #4555.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Nov 7, 2022
@skriss
update to latest Gateway API commit
388654c 
- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter

Updates projectcontour#4555.
Updates projectcontour#4738.

Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss added a commit to skriss/contour that referenced this issue Nov 7, 2022
@skriss
update to latest Gateway API commit
f4aa89d 
- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

Updates projectcontour#4555.
Updates projectcontour#4738.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss mentioned this issue Nov 7, 2022
Merged
skriss added a commit that referenced this issue Nov 9, 2022
@skriss
update to latest Gateway API commit (#4839)
033d7c1 
- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

Updates #4555.
Updates #4738.

Signed-off-by: Steve Kriss <krisss@vmware.com>
sunjayBhatia pushed a commit to sunjayBhatia/contour that referenced this issue Dec 14, 2022
@skriss @sunjayBhatia
drop support for ReferencePolicy (projectcontour#4830)
d2df138 
Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

Updates projectcontour#4555.

Signed-off-by: Steve Kriss <krisss@vmware.com>
sunjayBhatia pushed a commit to sunjayBhatia/contour that referenced this issue Dec 14, 2022
@skriss @sunjayBhatia
update to latest Gateway API commit (projectcontour#4839)
f1b170c 
- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

Updates projectcontour#4555.
Updates projectcontour#4738.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@sunjayBhatia sunjayBhatia mentioned this issue Dec 14, 2022
Merged
sunjayBhatia added a commit that referenced this issue Dec 14, 2022
@sunjayBhatia @skriss
Bump Gateway API to 0.6.0-rc.1 (#4929)
e7a8a0d 
* drop support for ReferencePolicy (#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (#4844)

* replace Gateway/Listener Ready conditions with Programmed (#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (#4891)

* Use generics for Gateway API pointer helpers (#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes #4555 
Fixes #4699 
Fixes #4848 

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
Repository owner moved this from In Progress to Done in Contour Dec 14, 2022
yangyy93 pushed a commit to projectsesame/contour that referenced this issue Feb 16, 2023
@sunjayBhatia @skriss @yangyy93
Bump Gateway API to 0.6.0-rc.1 (projectcontour#4929)
c703d01 
* drop support for ReferencePolicy (projectcontour#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (projectcontour#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (projectcontour#4844)

* replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (projectcontour#4891)

* Use generics for Gateway API pointer helpers (projectcontour#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes projectcontour#4555
Fixes projectcontour#4699
Fixes projectcontour#4848

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: yy <yang.yang@daocloud.io>
yangyy93 pushed a commit to projectsesame/contour that referenced this issue Feb 16, 2023
@sunjayBhatia @skriss @yangyy93
Bump Gateway API to 0.6.0-rc.1 (projectcontour#4929)
b460e03 
* drop support for ReferencePolicy (projectcontour#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (projectcontour#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (projectcontour#4844)

* replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (projectcontour#4891)

* Use generics for Gateway API pointer helpers (projectcontour#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes projectcontour#4555
Fixes projectcontour#4699
Fixes projectcontour#4848

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: yy <yang.yang@daocloud.io>
vmw-yingy pushed a commit to vmw-yingy/contour that referenced this issue Feb 28, 2023
@sunjayBhatia @skriss @vmw-yingy
Bump Gateway API to 0.6.0-rc.1 (projectcontour#4929)
4980d1a 
* drop support for ReferencePolicy (projectcontour#4830)

Drops support for ReferencePolicy which
has been replaced by ReferenceGrant in
Gateway API.

* update to latest Gateway API commit (projectcontour#4839)

- Update to v1beta1 ReferenceGrant
- HTTPRequestHeaderFilter -> HTTPHeaderFilter
- GatewayConditionScheduled -> GatewayConditionAccepted
- ListenerConditionDetached -> ListenerConditionAccepted

* updates for SupportedFeatures changes (projectcontour#4844)

* replace Gateway/Listener Ready conditions with Programmed (projectcontour#4849)

Replaces the "Ready" condition used for Gateways
and Listeners with "Programmed".

* update to Gateway API v0.6.0-rc1 (projectcontour#4891)

* Use generics for Gateway API pointer helpers (projectcontour#4905)

Can get rid of our existing gatewayapi package helpers for getting
pointers to gateway api types based on primitive types

Also found some more instances of v1alpha2 package being used where we
should switch to v1beta1

Fixes projectcontour#4555 
Fixes projectcontour#4699 
Fixes projectcontour#4848 

Signed-off-by: Steve Kriss <krisss@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: Steve Kriss <krisss@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skriss skriss

Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. blocked/needs-gateway-api Categorizes the issue or PR as blocked because it needs changes in Gateway API. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Contour
Status: Done
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

Bump Gateway API to 0.6.0-rc.1 sunjayBhatia/contour
2 participants
@skriss @youngnick