Fix mybinder #401
Open
Fix mybinder #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even after projectnessie#395 the demos do not work on mybinder.org. After some investigation it turned out that some tweaks are to the binder Dockerfile are required. This changes fixes a warning that the NB_USER and NB_UID args were not consumed. Those are now consumed - verifying the non-root user name and ID are the same as the ones used in the [base image](https://github.com/projectnessie/nessie-demos/pkgs/container/nessie-binder-demos). The actual fix is the ENTRYPOINT in the binder Dockerfile, which seems to be required, because binder passes custom arguments to jupyter. See https://mybinder.org/v2/gh/snazy/nessie-demos/fix-mybinder?labpath=notebooks%2Fnessie-iceberg-demo-nba.ipynb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even after #395 the demos do not work on mybinder.org. After some investigation it turned out that some tweaks are to the binder Dockerfile are required.
This changes fixes a warning that the NB_USER and NB_UID args were not consumed. Those are now consumed - verifying the non-root user name and ID are the same as the ones used in the base image.
The actual fix is the ENTRYPOINT in the binder Dockerfile, which seems to be required, because binder passes custom arguments to jupyter.
See https://mybinder.org/v2/gh/snazy/nessie-demos/fix-mybinder?labpath=notebooks%2Fnessie-iceberg-demo-nba.ipynb