Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mybinder #401

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix mybinder #401

wants to merge 2 commits into from

Commits on Nov 29, 2023

  1. Bump jupyterlab from 3.6.6 to 4.0.9

    @snazy
    snazy committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    6d5bcbc View commit details
    Browse the repository at this point in the history

  2. Fix mybinder 

    Even after projectnessie#395 the demos do not work on mybinder.org. After some investigation it turned out that some tweaks are to the binder Dockerfile are required.

This changes fixes a warning that the NB_USER and NB_UID args were not consumed. Those are now consumed - verifying the non-root user name and ID are the same as the ones used in the [base image](https://github.com/projectnessie/nessie-demos/pkgs/container/nessie-binder-demos).

The actual fix is the ENTRYPOINT in the binder Dockerfile, which seems to be required, because binder passes custom arguments to jupyter.

See https://mybinder.org/v2/gh/snazy/nessie-demos/fix-mybinder?labpath=notebooks%2Fnessie-iceberg-demo-nba.ipynb
    @snazy
    snazy committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    d93ad65 View commit details
    Browse the repository at this point in the history