Add support for Amazon Elasticsearch Service #443
Conversation
jmtsi
force-pushed
the
aws-signing
branch
3 times, most recently
from
2469ef1 to
283e7c4
Compare
| esAWS = kingpin.Flag("es.aws", "Enable support for Amazon Elasticsearch Service"). | ||
| Default("false").Envar("ES_AWS").Bool() | ||
| esAWSRegion = kingpin.Flag("es.aws-region", "Sets the AWS region"). | ||
| Default("").Envar("ES_AWS_REGION").String() |
There was a problem hiding this comment.
I have no idea why go fmt enforces this indentation... Would fail the CircleCI tests otherwise
Signed-off-by: Jami Karvanen <jami.karvanen@yle.fi>
|
Can we leverage https://github.com/prometheus/common/tree/main/sigv4 for the sigv4 part? does it make sense? |
|
Great idea, but It seems like it uses the default credential chain and AFAIK it doesn't support pod IAM roles without adding Maybe this implementation is good for now and I'll file an issue against the prometheus lib? |
|
Would love to see AWS ES signing support included -- Is this still being worked on? Does it need support? |
|
Any progress with this ticket? It would be very useful for AWS ES signing support to be included for us as we require it |
|
I am using AWS elasticsearch. I plan to use chart, prometheus-elasticsearch-exporter, to monitor it. A quick question here: es: |
This is based on @JackFazackerley's initial work from here: #353
I rebased this against the latest master and added additional credential provider, so this also works with pod IAM roles when running in EKS.