-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to assume an AWS role and renew expired credentials #653
Conversation
612ab14
to
26af5b8
Compare
Would be great if this landed as we're hitting the limitation right now (OpenSearch in a VPC, IAM role grants in the domain's access policy, EKS cluster) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd appreciate it if we can have this feature sooner ;)
Hey @sysadmind and @SuperQ, Happy New Year! Could we merge this pull request or do you miss something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking to have this merged ASAP please
@sysadmind @SuperQ can this be merged ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience. I have been very busy lately. I think this is very close. Just a few nitpicks.
Thanks for the PR!
26af5b8
to
7ec0e5b
Compare
Co-authored-by: Christoph Burmeister <christoph.burmeister@idealo.de> Signed-off-by: Steve Teuber <steve.teuber@idealo.de>
7ec0e5b
to
482b545
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks!
Hi all, thanks for getting this PR into the exporter! Do we have any plans for cutting a new release to release this feature? |
BREAKING CHANGES: The flag `--es.cluster_settings` has been renamed to `--collector.clustersettings`. * [CHANGE] Rename --es.cluster_settings to --collector.clustersettings * [FEATURE] Add ILM metrics #513 * [ENHANCEMENT] Add ElasticCloud node roles to role label #652 * [ENHANCEMENT] Add ability to use AWS IAM role for authentication #653 * [ENHANCEMENT] Add metric for index replica count #483 * [BUGFIX] Set elasticsearch_clusterinfo_version_info guage to 1 #728 * [BUGFIX] Fix index field counts with nested fields #675 --------- Signed-off-by: Joe Adams <github@joeadams.io>
Hi, we have added support to assume an AWS role which is required to get access from a different account.
By the way, I think the following issues can be closed: #353, #385, #400, #443, #636