Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to assume an AWS role and renew expired credentials #653

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

steveteuber
Copy link
Contributor

Hi, we have added support to assume an AWS role which is required to get access from a different account.
By the way, I think the following issues can be closed: #353, #385, #400, #443, #636

@corford
Copy link

corford commented Dec 15, 2022

Would be great if this landed as we're hitting the limitation right now (OpenSearch in a VPC, IAM role grants in the domain's access policy, EKS cluster)

Copy link

@ralbertha ralbertha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd appreciate it if we can have this feature sooner ;)

@steveteuber
Copy link
Contributor Author

steveteuber commented Jan 9, 2023

Hey @sysadmind and @SuperQ,

Happy New Year! Could we merge this pull request or do you miss something?

Copy link

@DCUKWS DCUKWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking to have this merged ASAP please

@DCUKWS
Copy link

DCUKWS commented Jan 19, 2023

@sysadmind @SuperQ can this be merged ?

Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience. I have been very busy lately. I think this is very close. Just a few nitpicks.

Thanks for the PR!

main.go Show resolved Hide resolved
pkg/roundtripper/roundtripper.go Show resolved Hide resolved
Co-authored-by: Christoph Burmeister <christoph.burmeister@idealo.de>
Signed-off-by: Steve Teuber <steve.teuber@idealo.de>
Copy link
Contributor

@sysadmind sysadmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@sysadmind sysadmind merged commit d55d6d2 into prometheus-community:master Jan 24, 2023
@chburmeister chburmeister deleted the aws-role-arn branch January 30, 2023 06:45
@patrickdash
Copy link

patrickdash commented Feb 16, 2023

Hi all, thanks for getting this PR into the exporter! Do we have any plans for cutting a new release to release this feature?

SuperQ added a commit that referenced this pull request Jun 29, 2023
BREAKING CHANGES:

The flag `--es.cluster_settings` has been renamed to `--collector.clustersettings`.

* [CHANGE] Rename --es.cluster_settings to --collector.clustersettings
* [FEATURE] Add ILM metrics #513
* [ENHANCEMENT] Add ElasticCloud node roles to role label #652
* [ENHANCEMENT] Add ability to use AWS IAM role for authentication #653
* [ENHANCEMENT] Add metric for index replica count #483
* [BUGFIX] Set elasticsearch_clusterinfo_version_info guage to 1 #728
* [BUGFIX] Fix index field counts with nested fields #675

---------

Signed-off-by: Joe Adams <github@joeadams.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants