Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enums not checking labelnames are valid #501

Closed
brian-brazil opened this issue Jan 7, 2020 · 0 comments
Closed

Enums not checking labelnames are valid #501

brian-brazil opened this issue Jan 7, 2020 · 0 comments
Labels
bug

Comments

@brian-brazil
Copy link
Contributor

This should throw an exception:

e = Enum("a", "b", labelnames=('taskId', ), states=["foo"])
e.state("foo")
xiwire pushed a commit to xiwire/client_python that referenced this issue Feb 29, 2020
Raise exception when logging to non-observable Enum (prometheus#501)
27fbe5f 
Signed-off-by: jxpp <jxpp@chigui.re>
@xiwire xiwire mentioned this issue Feb 29, 2020
Merged
brian-brazil pushed a commit that referenced this issue Feb 29, 2020
Raise exception when logging to non-observable Enum (#501) (#520)
72317c1 
Signed-off-by: jxpp <jxpp@chigui.re>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brian-brazil