Raise exception when logging to non-observable Enum (prometheus#501)

Signed-off-by: jxpp <jxpp@chigui.re>
xiwire · Feb 29, 2020 · 27fbe5f · 27fbe5f
1 parent 56a8a53
commit 27fbe5f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/prometheus_client/metrics.py b/prometheus_client/metrics.py
@@ -656,6 +656,7 @@ def _metric_init(self):
 
     def state(self, state):
         """Set enum metric state."""
+        self._raise_if_not_observable()
         with self._lock:
             self._value = self._states.index(state)
 

diff --git a/tests/test_core.py b/tests/test_core.py
@@ -428,6 +428,7 @@ def test_labels(self):
         self.assertEqual(0, self.registry.get_sample_value('el', {'l': 'a', 'el': 'a'}))
         self.assertEqual(0, self.registry.get_sample_value('el', {'l': 'a', 'el': 'b'}))
         self.assertEqual(1, self.registry.get_sample_value('el', {'l': 'a', 'el': 'c'}))
+        self.assertRaises(ValueError, self.labels.state, 'a')
 
     def test_overlapping_labels(self):
         with pytest.raises(ValueError):