otel flag changed #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `metrics-addr` is going away in the next release (see [breaking changes](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG.md#-breaking-changes-)). It has been replaced by `--set=service.telemetry.metrics.address` Signed-off-by: Alex Boten <aboten@lightstep.com>
Aneurysm9
approved these changes
Jan 21, 2022
roidelapluie
approved these changes
Jan 21, 2022
|
Can you also update the version in the file, to the version that has the new flags? currently it's v0.37.0 |
|
Hey all, first of all, thanks a lot for the PR @codeboten. I was trying to run this for the first time today and was handy. I've to do a few extra changes to successfully run it locally for the first time, with changes that don't exist yet on this repo. I've created a new PR where I included your changes, the update on the version suggested by @roidelapluie, and the swap on the repo to get the release. The PR it's here: #65 Not sure how we can go from here. |
|
Thanks for the reviews @roidelapluie @Aneurysm9, if you can have a look at #65, it updates the download url as well. |
|
Obsolete because of #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
metrics-addris going away in the next release (see breaking changes). It has been replaced by--set=service.telemetry.metrics.address