Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remote-writer-sender opentelemetry collector to reflect updates #65

Merged

Conversation

bmpandrade
Copy link
Contributor

This PR tries to reflect a few changes:

  1. Update to latest of opentelemetry-collector
  2. Update the repository from where to fetch the release, since opentelemetry-collector-releases is now the source.
  3. Update the --metrics.addr=:0 to reflect the coming changes.

As a test, I used a run based on a single test, but the output was similar for the rest of the suite.

Using go test --tags=compliance -run "TestRemoteWrite/otelcollector/Gauge" -v ./

Go before the changes:

✓  go test --tags=compliance -run "TestRemoteWrite/otelcollector/Gauge" -v ./
=== RUN   TestRemoteWrite
=== RUN   TestRemoteWrite/otelcollector
=== RUN   TestRemoteWrite/otelcollector/Gauge
=== PAUSE TestRemoteWrite/otelcollector/Gauge
=== CONT  TestRemoteWrite/otelcollector/Gauge
Downloading https://github.com/open-telemetry/opentelemetry-collector/releases/download/v0.37.0/otelcol_darwin_amd64
    main_test.go:99:
        	Error Trace:	main_test.go:99
        	            				main_test.go:70
        	Error:      	Received unexpected error:
        	            	fork/exec : no such file or directory
        	Test:       	TestRemoteWrite/otelcollector/Gauge
--- FAIL: TestRemoteWrite (0.51s)
    --- FAIL: TestRemoteWrite/otelcollector (0.00s)
        --- FAIL: TestRemoteWrite/otelcollector/Gauge (0.51s)
FAIL
FAIL	github.com/prometheus/compliance/remote_write	1.291s
FAIL

After the changes:

✓  go test --tags=compliance -run "TestRemoteWrite/otelcollector/Gauge" -v ./
=== RUN   TestRemoteWrite
=== RUN   TestRemoteWrite/otelcollector
=== RUN   TestRemoteWrite/otelcollector/Gauge
=== PAUSE TestRemoteWrite/otelcollector/Gauge
=== CONT  TestRemoteWrite/otelcollector/Gauge
Downloading https://github.com/open-telemetry/opentelemetry-collector-releases/releases/download/v0.42.0/otelcol_0.42.0_darwin_amd64.tar.gz
Decompressing /var/folders/6w/5pg5lc_d2vzbwn40xlb_44d80000gp/T/2524267209
Extracting otelcol
--- PASS: TestRemoteWrite (15.60s)
    --- PASS: TestRemoteWrite/otelcollector (0.00s)
        --- PASS: TestRemoteWrite/otelcollector/Gauge (15.59s)
PASS
ok  	github.com/prometheus/compliance/remote_write	16.008s

@bmpandrade bmpandrade mentioned this pull request Jan 24, 2022
…s and latest releases.

Signed-off-by: Bruno Andrade <brunompandrade@gmail.com>
@bmpandrade bmpandrade force-pushed the otel-remote-writer-sender-update branch from afde5c4 to 3e9cce2 Compare January 24, 2022 15:16
@bmpandrade
Copy link
Contributor Author

Sorry, I forgot to do the sign-off on the commit, there's way it shows above as force-pushed.

Copy link

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the download as well!

@gouthamve gouthamve merged commit f048288 into prometheus:main Jan 26, 2022
gouthamve added a commit to gouthamve/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2022
See: prometheus/compliance#65

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
jpkrohling pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Jan 26, 2022
See: prometheus/compliance#65

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
@bmpandrade bmpandrade deleted the otel-remote-writer-sender-update branch February 1, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants