Add projector manager options to Symfony Console commands #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 210
💛 - Coveralls |
|
@ambroisemaupate sorry for being late on this. Thanks for PR! Tests fail with older event store versions. The projector option "update lock threshold" was added in 7.3.4. Minimum requirement for the bundle is event-store 7.0 Can you work around the issue to make the tests pass? |
|
@codeliner Thanks for your answer. I’m really happy to contribute to your awesome ES framework. I’ll find out a solution, testing if constants exist before adding them as Command options. |
Merged
|
Projections options were released with 0.9.0 (#69) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #59
Works for: