Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

projection options #69

Merged
merged 1 commit into from
Aug 3, 2020
Merged

projection options #69

merged 1 commit into from
Aug 3, 2020

Conversation

unixslayer
Copy link
Member

@codeliner @prolic

  • I was not able to pass projection options when defining projections so it couldn't be used when running projection with console command

@unixslayer unixslayer force-pushed the projection_options branch 3 times, most recently from 81ecff8 to c4a1ec7 Compare July 29, 2020 07:55
@coveralls
Copy link

coveralls commented Jul 29, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 253

  • 49 of 55 (89.09%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 89.231%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/DependencyInjection/Compiler/ProjectionOptionsPass.php 25 26 96.15%
src/Projection/Options/ProjectionOptions.php 2 3 66.67%
src/Command/AbstractProjectionCommand.php 0 4 0.0%
Totals Coverage Status
Change from base Build 244: 0.3%
Covered Lines: 522
Relevant Lines: 585
💛 - Coveralls

@unixslayer unixslayer force-pushed the projection_options branch 3 times, most recently from 81e9053 to 0936674 Compare July 29, 2020 13:56
@prolic
Copy link
Member

prolic commented Jul 29, 2020

can you add something to the docs on how to use it?

@unixslayer
projection options
f70233e 
- I was not able to pass projection options when defining projections so it couldn't be used when running projection with console command
- projection options can be defined either in central way or as tagged service
- supplementing the documentation with projection management
@unixslayer unixslayer force-pushed the projection_options branch from 0936674 to f70233e Compare July 31, 2020 20:35
@unixslayer
Copy link
Member Author

@prolic done. I've also supplement documentation with projection management. I somehow missed #67 and #59 ;)

@prolic prolic merged commit 3d7a30e into prooph:master Aug 3, 2020
@prolic
Copy link
Member

prolic commented Aug 3, 2020

awesome @unixslayer , thank you

@unixslayer unixslayer deleted the projection_options branch August 3, 2020 18:35
This was referenced Apr 21, 2021
Closed
Closed
@webdevilopers webdevilopers mentioned this pull request Jun 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unixslayer @coveralls @prolic