Bump enqueue version to ^0.10 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kochen
reviewed
Jan 4, 2021
Year bump is required for CI checks to pass, is it worth the effort of splitting it out? |
|
No that's fine. Keep it like this. I will check it the next few days. Super
busy, sorry.
…On Tue, Jan 5, 2021, 03:33 George ***@***.***> wrote:
The version bump is a change in one file, yet 18 files were changed.
I would consider splitting the year bump to its own PR.
Year bump is required for CI checks to pass, is it worth the effort of
splitting it out?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADAJPCHUGKIAD7UOQOHHHTSYKXC3ANCNFSM4VTBDOAA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardise around enqueue/simple-client which includes the previously required dependencies) so should ease upgrades going forwards