-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v24.0 python module failed to build at Generating google/protobuf/unittest_arena_pb2.py
#13501
Comments
zhangskz
added
python
24.x
and removed
untriaged
auto added to all issues by default when created.
labels
Aug 10, 2023
copybara-service bot
pushed a commit
that referenced
this issue
Aug 10, 2023
This proto is only used in C++ tests, and doesn't need to be built in python. Python doesn't support editions yet, so we should just remove it for now. Closes #13501 PiperOrigin-RevId: 555630721
copybara-service bot
pushed a commit
that referenced
this issue
Aug 10, 2023
This proto is only used in C++ tests, and doesn't need to be built in python. Python doesn't support editions yet, so we should just remove it for now. This also fixes some other issues with setup.py where tests fail. Closes #13501 PiperOrigin-RevId: 555630721
copybara-service bot
pushed a commit
that referenced
this issue
Aug 10, 2023
This proto is only used in C++ tests, and doesn't need to be built in python. Python doesn't support editions yet, so we should just remove it for now. This also fixes some other issues with setup.py where tests fail. Closes #13501 PiperOrigin-RevId: 555630721
copybara-service bot
pushed a commit
that referenced
this issue
Aug 10, 2023
This proto is only used in C++ tests, and doesn't need to be built in python. Python doesn't support editions yet, so we should just remove it for now. This also fixes some other issues with setup.py where tests fail. Closes #13501 PiperOrigin-RevId: 555630721
copybara-service bot
pushed a commit
that referenced
this issue
Aug 10, 2023
This proto is only used in C++ tests, and doesn't need to be built in python. Python doesn't support editions yet, so we should just remove it for now. This also fixes some other issues with setup.py where tests fail. Closes #13501 PiperOrigin-RevId: 555630721
zhangskz
pushed a commit
to zhangskz/protobuf
that referenced
this issue
Aug 14, 2023
This proto is only used in C++ tests, and doesn't need to be built in python. Python doesn't support editions yet, so we should just remove it for now. This also fixes some other issues with setup.py where tests fail. Closes protocolbuffers#13501 PiperOrigin-RevId: 555681295
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of protobuf and what language are you using?
Version: v24.0
Language: Python
What operating system (Linux, Windows, ...) and version?
Linux, Freedesktop SDK master
What runtime / compiler are you using (e.g., python version or gcc version)
Python 3.11.4
GCC 13.2.0
What did you do?
Steps to reproduce the behavior:
cd python
./setup.py build
What did you expect to see
Build without error.
What did you see instead?
Anything else we should know about your project / environment
The issue was introduced at c3b72b9
Downstream MR link: https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/merge_requests/14347
The text was updated successfully, but these errors were encountered: