Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v24.0 python module failed to build at Generating google/protobuf/unittest_arena_pb2.py #13501

Closed
cheese opened this issue Aug 10, 2023 · 0 comments
Assignees

Comments

@cheese
Copy link

cheese commented Aug 10, 2023

What version of protobuf and what language are you using?
Version: v24.0
Language: Python

What operating system (Linux, Windows, ...) and version?

Linux, Freedesktop SDK master

What runtime / compiler are you using (e.g., python version or gcc version)

Python 3.11.4
GCC 13.2.0

What did you do?
Steps to reproduce the behavior:

  1. Build and install v24.0 protobuf
  2. cd python
  3. ./setup.py build
  4. See error

What did you expect to see

Build without error.

What did you see instead?

/buildstream-build/python/./setup.py:40: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
  import pkg_resources
/usr/lib/python3.11/site-packages/setuptools/dist.py:945: SetuptoolsDeprecationWarning: The namespace_packages parameter is deprecated.
!!

        ********************************************************************************
        Please replace its usage with implicit namespaces (PEP 420).

        See https://setuptools.pypa.io/en/latest/references/keywords.html#keyword-namespace-packages for details.
        ********************************************************************************

!!
  ep.load()(self, ep.name, value)
running build_py
Generating google/protobuf/unittest_arena_pb2.py...
google/protobuf/unittest_arena.proto: is an editions file, but code generator --python_out hasn't been updated to support editions yet. Please ask the owner of this code generator to add support or switch back to proto2/proto3.

Anything else we should know about your project / environment
The issue was introduced at c3b72b9

Downstream MR link: https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/merge_requests/14347

@cheese cheese added the untriaged auto added to all issues by default when created. label Aug 10, 2023
@zhangskz zhangskz added python 24.x and removed untriaged auto added to all issues by default when created. labels Aug 10, 2023
copybara-service bot pushed a commit that referenced this issue Aug 10, 2023
This proto is only used in C++ tests, and doesn't need to be built in python.  Python doesn't support editions yet, so we should just remove it for now.

Closes #13501

PiperOrigin-RevId: 555630721
copybara-service bot pushed a commit that referenced this issue Aug 10, 2023
This proto is only used in C++ tests, and doesn't need to be built in python.  Python doesn't support editions yet, so we should just remove it for now.  This also fixes some other issues with setup.py where tests fail.

Closes #13501

PiperOrigin-RevId: 555630721
copybara-service bot pushed a commit that referenced this issue Aug 10, 2023
This proto is only used in C++ tests, and doesn't need to be built in python.  Python doesn't support editions yet, so we should just remove it for now.  This also fixes some other issues with setup.py where tests fail.

Closes #13501

PiperOrigin-RevId: 555630721
copybara-service bot pushed a commit that referenced this issue Aug 10, 2023
This proto is only used in C++ tests, and doesn't need to be built in python.  Python doesn't support editions yet, so we should just remove it for now.  This also fixes some other issues with setup.py where tests fail.

Closes #13501

PiperOrigin-RevId: 555630721
copybara-service bot pushed a commit that referenced this issue Aug 10, 2023
This proto is only used in C++ tests, and doesn't need to be built in python.  Python doesn't support editions yet, so we should just remove it for now.  This also fixes some other issues with setup.py where tests fail.

Closes #13501

PiperOrigin-RevId: 555630721
zhangskz pushed a commit to zhangskz/protobuf that referenced this issue Aug 14, 2023
This proto is only used in C++ tests, and doesn't need to be built in python.  Python doesn't support editions yet, so we should just remove it for now.  This also fixes some other issues with setup.py where tests fail.

Closes protocolbuffers#13501

PiperOrigin-RevId: 555681295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants