Backport 24.x fixes for absl dep update and setup.py #13534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This proto is only used in C++ tests, and doesn't need to be built in python. Python doesn't support editions yet, so we should just remove it for now. This also fixes some other issues with setup.py where tests fail. Closes protocolbuffers#13501 PiperOrigin-RevId: 555681295
zhangskz
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
haberman
approved these changes
Aug 14, 2023
…rs#13515) * Update absl submodule and dep to latest 20230802.0 LTS * Fix absl submodule * Update submodule * Update absl submodule to correct commit
zhangskz
force-pushed
the
backport-24-x
branch
from
90a93d2
to
63cbb63
Compare
|
Updated to cherry-pick original git commit including submodule dep for absl fix (instead of copybara commit which excludes it) |
zhangskz
requested review from
mkruskal-google
and removed request for
deannagarcia and
a team
zhangskz
added
the
🅰️ safe for tests
github-actions
bot
removed
the
🅰️ safe for tests
haberman
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports fixes for #13499 and #13501 to 24.x branch