-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add api support for abci streaming to external systems #952
Conversation
Codecov Report
@@ Coverage Diff @@
## main #952 +/- ##
==========================================
- Coverage 56.79% 56.76% -0.03%
==========================================
Files 181 182 +1
Lines 22273 22333 +60
==========================================
+ Hits 12649 12678 +29
- Misses 8651 8677 +26
- Partials 973 978 +5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs unit/integration tests.
I'm also unsure what the difference between this stuff and the plugins stuff is. An actual use case and some unit tests would probably help with that respect though.
20ca01d
to
f1b6805
Compare
Co-authored-by: Daniel Wedul <github@wedul.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more small things.
Co-authored-by: Daniel Wedul <github@wedul.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this PR looks good to me, the "omitted" use case i am not sure i understand but it being controlled by the flag makes it sound code wise..
closing this for now in favor of a |
Description
Adds support for streaming
BeginBlocker
andEndBlocker
request and responses to external systems.closes: #940
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes