Use Epoch boundary cache to retrieve balances #12083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
force-pushed
the
use_epoch_boundary_cache_to_get_balances
branch
from
db1d346 to
01aa9d4
Compare
terencechain
previously approved these changes
Mar 6, 2023
There was a problem hiding this comment.
Adding some rationale to this. Given fork choice store needs the balances for the justified checkpoint. Prysm uses StateByRoot and we want the state to be in the epoch boundary cache as often as we can for a better hit ratio.
This PR accomplishes the following
- uses epoch boundary cache inStateByRoot
- saves the states on batches before sending them to fork choices store
nisdas
reviewed
Mar 6, 2023
| if err := s.cfg.StateGen.SaveState(ctx, r, st); err != nil { | ||
| return err | ||
| } | ||
| } | ||
| // Also saves the last post state which to be used as pre state for the next batch. | ||
| lastB := blks[len(blks)-1] | ||
| if err := s.cfg.StateGen.SaveState(ctx, lastBR, preState); err != nil { |
nisdas
previously approved these changes
Mar 6, 2023
nisdas
approved these changes
Mar 6, 2023
delete-merged-branch
bot
deleted the
use_epoch_boundary_cache_to_get_balances
branch
terencechain
pushed a commit
that referenced
this pull request
Mar 6, 2023
* Use Epoch boundary cache to retrieve balances * save boundary states before inserting to forkchoice * move up last block save * remove boundary checks on balances * fix ordering --------- Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
terencechain
pushed a commit
that referenced
this pull request
Mar 6, 2023
* Use Epoch boundary cache to retrieve balances * save boundary states before inserting to forkchoice * move up last block save * remove boundary checks on balances * fix ordering --------- Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
Taranpreet26311
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Use Epoch boundary cache to retrieve balances * save boundary states before inserting to forkchoice * move up last block save * remove boundary checks on balances * fix ordering --------- Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 22, 2024
…12675) * Remove Feature Flag From Prater (#12082) * Use Epoch boundary cache to retrieve balances (#12083) * Use Epoch boundary cache to retrieve balances * save boundary states before inserting to forkchoice * move up last block save * remove boundary checks on balances * fix ordering --------- Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> * create the log file along with its parent directory if not present * only give ReadWritePermissions to the log file * use io/file package to create the parent directories * fix ci related issues * add regression tests * run gazelle * fix tests * remove print statements * gazelle * Remove failing test for MkdirAll, this failure is not expected --------- Co-authored-by: Nishant Das <nishdas93@gmail.com> Co-authored-by: Potuz <potuz@prysmaticlabs.com> Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Remove Feature Flag From Prater (#12082) * Use Epoch boundary cache to retrieve balances (#12083) * Use Epoch boundary cache to retrieve balances * save boundary states before inserting to forkchoice * move up last block save * remove boundary checks on balances * fix ordering --------- Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> * chore: fix unfound image * fix link --------- Co-authored-by: Nishant Das <nishdas93@gmail.com> Co-authored-by: Potuz <potuz@prysmaticlabs.com> Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com> Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retrieving balances by Root for forkchoice, use the epoch boundary cache to retrieve the justified checkpoint balances