create the log file along with its parent directory if not present #12675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use Epoch boundary cache to retrieve balances * save boundary states before inserting to forkchoice * move up last block save * remove boundary checks on balances * fix ordering --------- Co-authored-by: prylabs-bulldozer[bot] <58059840+prylabs-bulldozer[bot]@users.noreply.github.com>
bharath-123
force-pushed
the
create-log-file
branch
from
8e84507 to
967d7d3
Compare
io/logs/logutil.go
Outdated
| if err := os.MkdirAll(filepath.Dir(logFileName), params.BeaconIoConfig().ReadWriteExecutePermissions); err != nil { | ||
| return err | ||
| } | ||
| f, err := os.OpenFile(logFileName, os.O_CREATE|os.O_WRONLY|os.O_APPEND, params.BeaconIoConfig().ReadWriteExecutePermissions) // #nosec G304 |
There was a problem hiding this comment.
This changes the file permissions. Does the log file need +x?
Suggested change
| f, err := os.OpenFile(logFileName, os.O_CREATE|os.O_WRONLY|os.O_APPEND, params.BeaconIoConfig().ReadWriteExecutePermissions) // #nosec G304 | |
| f, err := os.OpenFile(logFileName, os.O_CREATE|os.O_WRONLY|os.O_APPEND, params.BeaconIoConfig().ReadWritePermissions) // #nosec G304 |
There was a problem hiding this comment.
will fix this. that was not an intended change. The ReadWriteExecute is mainly for the directory to create a file within it.
There was a problem hiding this comment.
the log file doesnt require +x
There was a problem hiding this comment.
should be resolved now
nisdas
reviewed
Aug 1, 2023
io/logs/logutil.go
Outdated
| @@ -20,6 +21,9 @@ func addLogWriter(w io.Writer) { | |||
| // ConfigurePersistentLogging adds a log-to-file writer. File content is identical to stdout. | |||
| func ConfigurePersistentLogging(logFileName string) error { | |||
| logrus.WithField("logFileName", logFileName).Info("Logs will be made persistent") | |||
| if err := os.MkdirAll(filepath.Dir(logFileName), params.BeaconIoConfig().ReadWriteExecutePermissions); err != nil { | |||
There was a problem hiding this comment.
please use from our io/file package to create these paths, it is the standard method we use across prysm for our file i/o operations
bharath-123
force-pushed
the
create-log-file
branch
from
1ccc121 to
386c186
Compare
nisdas
reviewed
Aug 7, 2023
… create-log-file
bharath-123
force-pushed
the
create-log-file
branch
2 times, most recently
from
4caf378 to
2920247
Compare
nisdas
reviewed
Aug 22, 2023
| @@ -24,3 +27,58 @@ func TestMaskCredentialsLogging(t *testing.T) { | |||
| require.Equal(t, MaskCredentialsLogging(test.url), test.maskedUrl) | |||
| } | |||
| } | |||
|
|
|||
| func TestConfigurePersistantLogging(t *testing.T) { | |||
There was a problem hiding this comment.
For temporary directories for tests use t.TempDir() , this gets cleaned up by the test runner after the test is executed.
bharath-123
force-pushed
the
create-log-file
branch
from
2920247 to
c52cd9e
Compare
…create-log-file
… create-log-file
… create-log-file
… create-log-file
… create-log-file
… create-log-file
…into create-log-file
prestonvanloon
previously approved these changes
Mar 22, 2024
prestonvanloon
previously approved these changes
Mar 22, 2024
prestonvanloon
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enhancement
What does this PR do? Why is it needed?
Currently, when we specify a log file for the beacon chain node and if the log file parent directories are not present then we don't create the directory and error out. This PR adds support to create the parent directories if not present.
Which issues(s) does this PR fix?
Fixes (#12496)
Other notes for review