Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert reorg of late blocks flag #12146

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Invert reorg of late blocks flag #12146

merged 2 commits into from
Mar 17, 2023

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Mar 16, 2023

Invert feature flag to reorg late blocks by default

@potuz potuz added Ready For Review A pull request ready for code review V4 labels Mar 16, 2023
@potuz potuz requested a review from a team as a code owner March 16, 2023 19:00
@potuz potuz requested review from terencechain, rkapka and nisdas March 16, 2023 19:00
Comment on lines +44 to +46
disableReorgLateBlocks = &cli.BoolFlag{
Name: "disable-reorg-late-blocks",
Usage: "Disables reorgs of late blocks",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remember to update this for our testnet nodes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@potuz potuz merged commit 5beb5e8 into develop Mar 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the invert-reorg-flag branch March 17, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants