Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert reorg of late blocks flag #12146

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Invert reorg of late blocks flag #12146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c97533
Invert reorg of late blocks flag
potuz Mar 16, 2023
6311de7
add flag to beacon node
potuz Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions config/features/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,9 @@ func ConfigureBeaconChain(ctx *cli.Context) error {
cfg.DisableGRPCConnectionLogs = true
}

cfg.DisableReorgLateBlocks = true
if ctx.Bool(enableReorgLateBlocks.Name) {
logEnabled(enableReorgLateBlocks)
cfg.DisableReorgLateBlocks = false
if ctx.Bool(disableReorgLateBlocks.Name) {
logEnabled(disableReorgLateBlocks)
cfg.DisableReorgLateBlocks = true
}
if ctx.Bool(disableBroadcastSlashingFlag.Name) {
logDisabled(disableBroadcastSlashingFlag)
Expand Down
8 changes: 4 additions & 4 deletions config/features/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@ var (
Name: "disable-grpc-connection-logging",
Usage: "Disables displaying logs for newly connected grpc clients",
}
enableReorgLateBlocks = &cli.BoolFlag{
Name: "enable-reorg-late-blocks",
Usage: "Enables reorgs of late blocks",
disableReorgLateBlocks = &cli.BoolFlag{
Name: "disable-reorg-late-blocks",
Usage: "Disables reorgs of late blocks",
Comment on lines +44 to +46
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remember to update this for our testnet nodes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

}
writeWalletPasswordOnWebOnboarding = &cli.BoolFlag{
Name: "write-wallet-password-on-web-onboarding",
Expand Down Expand Up @@ -163,7 +163,7 @@ var BeaconChainFlags = append(deprecatedBeaconFlags, append(deprecatedFlags, []c
enableHistoricalSpaceRepresentation,
disableStakinContractCheck,
disableVecHTR,
enableReorgLateBlocks,
disableReorgLateBlocks,
disableForkChoiceDoublyLinkedTree,
disableGossipBatchAggregation,
SaveFullExecutionPayloads,
Expand Down