Add support for engine_exchangeCapabilities #12224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
Apr 4, 2023
| @@ -30,6 +30,20 @@ import ( | |||
| "go.opencensus.io/trace" | |||
| ) | |||
|
|
|||
| var ( | |||
There was a problem hiding this comment.
I guess we should also include ExchangeCapabilities itself.
There was a problem hiding this comment.
In the spec it says "The engine_exchangeCapabilities method MUST NOT be returned in the response list.". So I removed it from the list of our own supported ones as well.
Would it be better to include it?
| unsupported = append(unsupported, s1) | ||
| } | ||
| } | ||
| if len(unsupported) != 0 { |
There was a problem hiding this comment.
A unit test checking the log would be nice
| } | ||
| } | ||
| if len(unsupported) != 0 { | ||
| log.Warnf("Please update, detected the following unsupported engine methods: %s", unsupported) |
There was a problem hiding this comment.
Please update is too vague. Update what?
rkapka
approved these changes
Apr 17, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This PR adds engine_exchangecapabilities. Which is used to exchange a list of CL/EL supported engine methods.
Which issues(s) does this PR fix?
Fixes #11921
Other notes for review