Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json methods for ExchangeCapabilities #14523

Closed
wants to merge 2 commits into from
Closed

Conversation

saolyn
Copy link
Contributor

@saolyn saolyn commented Oct 10, 2024

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

This PR fixes our implementation of engine_exchangecapabilities as I didn't include the JSON Marshaling and Unmarshaling functions when first working on this #12224.

Which issues(s) does this PR fix?

N/A

Other notes for review

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@saolyn saolyn requested a review from a team as a code owner October 10, 2024 08:26
@saolyn saolyn requested review from kasey and potuz October 10, 2024 08:26
@saolyn
Copy link
Contributor Author

saolyn commented Oct 14, 2024

Closed in favor of #14533

@saolyn saolyn closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant