-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create the log file along with its parent directory if not present #12675
Merged
prestonvanloon
merged 27 commits into
prysmaticlabs:develop
from
bharath-123:create-log-file
Mar 22, 2024
+43
−0
Merged
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
dfd8bcf
Remove Feature Flag From Prater (#12082)
nisdas e2fa7d4
Use Epoch boundary cache to retrieve balances (#12083)
potuz 16f9f7d
Merge tag 'v4.0.2'
prestonvanloon 2674e20
Merge tag 'v4.0.3'
prestonvanloon 967d7d3
create the log file along with its parent directory if not present
bharath-123 e3a5e73
only give ReadWritePermissions to the log file
bharath-123 110e81c
Merge branch 'develop' of https://github.com/prysmaticlabs/prysm into…
bharath-123 386c186
use io/file package to create the parent directories
bharath-123 0d787bf
Merge branch 'develop' of https://github.com/prysmaticlabs/prysm into…
bharath-123 f31cea4
fix ci related issues
bharath-123 0c05a53
Merge branch 'develop' of https://github.com/prysmaticlabs/prysm into…
bharath-123 c52cd9e
add regression tests
bharath-123 4d1c3d6
Merge branch 'master' of https://github.com/prysmaticlabs/prysm into …
bharath-123 bcfbc8d
Merge branch 'develop' of https://github.com/prysmaticlabs/prysm into…
bharath-123 52c279f
Merge branch 'develop' of https://github.com/prysmaticlabs/prysm into…
bharath-123 f6d0da3
run gazelle
bharath-123 b42f576
Merge branch 'develop' of https://github.com/prysmaticlabs/prysm into…
bharath-123 35ca363
Merge branch 'develop' of https://github.com/prysmaticlabs/prysm into…
bharath-123 1cd7df8
fix tests
bharath-123 e4c691b
Merge branch 'develop' into create-log-file
bharath-123 ef0e7f0
remove print statements
bharath-123 eaba83c
Merge branch 'develop' of https://github.com/prysmaticlabs/prysm into…
bharath-123 7991d9c
Merge branch 'create-log-file' of https://github.com/bharath-123/prys…
bharath-123 be2ee88
Merge branch 'develop' into create-log-file
bharath-123 5266bcc
Merge branch 'develop' into create-log-file
prestonvanloon 5636470
gazelle
prestonvanloon 6c8719a
Remove failing test for MkdirAll, this failure is not expected
prestonvanloon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For temporary directories for tests use
t.TempDir()
, this gets cleaned up by the test runner after the test is executed.