Electra: Consensus types additions #13925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
prestonvanloon
force-pushed
the
electra-consensus-types
branch
3 times, most recently
from
3550c7c to
e2aa01e
Compare
kasey
reviewed
Apr 26, 2024
prestonvanloon
force-pushed
the
electra-consensus-types
branch
from
e2aa01e to
fc373b3
Compare
kasey
reviewed
Apr 26, 2024
prestonvanloon
force-pushed
the
electra-consensus-types
branch
from
fc373b3 to
84ab470
Compare
james-prysm
reviewed
Apr 26, 2024
james-prysm
reviewed
Apr 26, 2024
potuz
reviewed
Apr 26, 2024
james-prysm
reviewed
Apr 26, 2024
| @@ -122,13 +122,9 @@ func (b *SignedBeaconBlock) SetBLSToExecutionChanges(blsToExecutionChanges []*et | |||
|
|
|||
| // SetBlobKzgCommitments sets the blob kzg commitments in the block. | |||
| func (b *SignedBeaconBlock) SetBlobKzgCommitments(c [][]byte) error { | |||
| switch b.version { | |||
| case version.Phase0, version.Altair, version.Bellatrix, version.Capella: | |||
| if b.version < version.Deneb { | |||
There was a problem hiding this comment.
nice small improvement here
| // executionPayloadHeaderElectra is a convenience wrapper around a blinded beacon block body's execution header data structure. | ||
| // This wrapper allows us to conform to a common interface so that beacon | ||
| // blocks for future forks can also be applied across Prysm without issues. | ||
| type executionPayloadHeaderElectra struct { |
There was a problem hiding this comment.
I'd also consider adding unit tests for all the new methods. Here is an example what I did for ePBS. Feel free to copy:
rkapka
reviewed
Apr 27, 2024
| } | ||
| cp := eth.CopySignedBeaconBlockElectra(pb.(*eth.SignedBeaconBlockElectra)) | ||
| return initSignedBlockFromProtoElectra(cp) | ||
|
|
| @@ -1079,13 +1223,20 @@ func (b *BeaconBlockBody) BlobKzgCommitments() ([][]byte, error) { | |||
| switch b.version { | |||
| case version.Phase0, version.Altair, version.Bellatrix, version.Capella: | |||
There was a problem hiding this comment.
Can we refactor this to if b.version < version.Deneb?
prestonvanloon
force-pushed
the
electra-consensus-types
branch
from
fa9d8fa to
1824295
Compare
Co-authored-by: Kasey Kirkham <kasey@users.noreply.github.com>
|
This landed in #13937 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Some of the consensus types changes for Electra.
Which issues(s) does this PR fix?
Required for #13919
Other notes for review
Depends on #13921, #13923, and #13924. Merge those before this can be marked as ready for review.