Electra attestation interfaces #13937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 32ad5009537bc5ec0e6caf9f52143d380d00be85.
This reverts commit f39644ed3cb6f3964fc6c86fdf4bd5de2a9668c8.
…p-7549 # Conflicts: # config/params/config.go # consensus-types/blocks/types.go # consensus-types/mock/block.go # proto/prysm/v1alpha1/attestation.go # proto/prysm/v1alpha1/attestation.pb.go # proto/prysm/v1alpha1/attestation.proto # proto/prysm/v1alpha1/beacon_block.pb.go # proto/prysm/v1alpha1/beacon_block.proto # proto/prysm/v1alpha1/cloners.go # proto/prysm/v1alpha1/generated.ssz.go # proto/ssz_proto_library.bzl
rkapka
force-pushed
the
electra-att-interfaces
branch
2 times, most recently
from
05787e7 to
d2628f3
Compare
rkapka
force-pushed
the
electra-att-interfaces
branch
3 times, most recently
from
1122d7a to
05787e7
Compare
james-prysm
reviewed
Apr 30, 2024
| @@ -671,5 +671,5 @@ func ValidatorMaxEffectiveBalance(val *ethpb.Validator) uint64 { | |||
| if HasCompoundingWithdrawalCredential(val) { | |||
| return params.BeaconConfig().MaxEffectiveBalanceElectra | |||
| } | |||
| return params.BeaconConfig().MinActivationBalance // TODO: Add test that MinActivationBalance == (old) MaxEffectiveBalance | |||
| return params.BeaconConfig().MinActivationBalance | |||
There was a problem hiding this comment.
I added this test in #13921 and forgot to remove the TODO
james-prysm
reviewed
Apr 30, 2024
| "attestationSlot1": slashing.GetFirstAttestation().GetData().Slot, | ||
| "beaconBlockRoot1": fmt.Sprintf("%#x", bytesutil.Trunc(slashing.GetFirstAttestation().GetData().BeaconBlockRoot)), | ||
| "sourceEpoch1": slashing.GetFirstAttestation().GetData().Source.Epoch, | ||
| "targetEpoch1": slashing.GetFirstAttestation().GetData().Target.Epoch, |
There was a problem hiding this comment.
not for this pr but maybe we should rename this function as it can be easily misused and accidentally swapped with GetSecondAttestation
james-prysm
reviewed
Apr 30, 2024
| GetSignature() []byte | ||
| } | ||
|
|
||
| func (a *Attestation) Version() int { |
There was a problem hiding this comment.
we should have a check for these attestations/sub types using var _ = MyInterface(concrete type)
There was a problem hiding this comment.
@james-prysm i think that would have the same circular dependency issue that is mentioned on line 10
james-prysm
reviewed
Apr 30, 2024
…Slashings and SetAttestations
prestonvanloon
previously approved these changes
Apr 30, 2024
james-prysm
reviewed
Apr 30, 2024
| } | ||
|
|
||
| // PbCapella -- | ||
| func (executionPayloadHeaderElectra) PbCapella() (*enginev1.ExecutionPayloadCapella, error) { |
There was a problem hiding this comment.
will need to be removed again as part of kasey's changes
james-prysm
reviewed
Apr 30, 2024
| @@ -13,7 +13,7 @@ import ( | |||
| ) | |||
|
|
|||
| // Proto converts the signed beacon block to a protobuf object. | |||
| func (b *SignedBeaconBlock) Proto() (proto.Message, error) { | |||
| func (b *SignedBeaconBlock) Proto() (proto.Message, error) { // nolint:gocognit | |||
There was a problem hiding this comment.
probably a todo to improve
There was a problem hiding this comment.
I dont think we can really make this much less complex :(
prestonvanloon
approved these changes
Apr 30, 2024
james-prysm
approved these changes
Apr 30, 2024
3 tasks
nisdas
pushed a commit
that referenced
this pull request
Jul 4, 2024
* config values * block protos * get_committee_indices * proto and ssz * attestation interface * Revert "Auxiliary commit to revert individual files from deadb21" This reverts commit 32ad5009537bc5ec0e6caf9f52143d380d00be85. * todos * get_attesting_indices * Revert "Auxiliary commit to revert individual files from dd27897" This reverts commit f39644ed3cb6f3964fc6c86fdf4bd5de2a9668c8. * beacon spec changes * Fix pending attestation. Build ok * Electra: add electra version * Electra: consensus types * gocognit exclusion * @potuz's suggestion * build fix * interfaces for indexed att and slashing * indexed att usage * BuildSignedBeaconBlockFromExecutionPayload * slashing usage * grpc stubs * remove unused methods * Electra attestation interfaces * cleanup * tests * make linter happy * simple casting * test fixes * Fix spectest failures * Regen pb and ssz files * Handle "not ok" type assertion cases * Setters that check version should always return an error. SetAttesterSlashings and SetAttestations * gofmt * Fix TestMinSpanChunksSlice_CheckSlashable --------- Co-authored-by: terence tsao <terence@prysmaticlabs.com> Co-authored-by: Preston Van Loon <preston@pvl.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.