Electra: EIP-7251 Update process_voluntary_exit
#14176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
reviewed
Jul 2, 2024
| @@ -186,6 +190,18 @@ func verifyExitConditions(validator state.ReadOnlyValidator, currentSlot primiti | |||
| params.BeaconConfig().ShardCommitteePeriod, | |||
| validator.ActivationEpoch()+params.BeaconConfig().ShardCommitteePeriod, | |||
| ) | |||
| } | |||
|
|
|||
| if st.Version() >= version.Electra { | |||
There was a problem hiding this comment.
do we want to break this out from the core blocks into electra?
There was a problem hiding this comment.
Eventually. Breaking this out would involve breaking the other forks out and it would be a large change. Currently trying to get to devnet-1 while taking note of this. I'll take a note of this, thanks
prestonvanloon
force-pushed
the
electra-process_voluntary_exit
branch
from
e6d3240 to
ae696b6
Compare
prestonvanloon
force-pushed
the
electra-process_voluntary_exit
branch
from
ae696b6 to
f5e6376
Compare
potuz
requested changes
Jul 3, 2024
beacon-chain/core/blocks/exit.go
Outdated
| // # Verify signature | ||
| // domain = get_domain(state, DOMAIN_VOLUNTARY_EXIT, voluntary_exit.epoch) | ||
| // signing_root = compute_signing_root(voluntary_exit, domain) | ||
| // assert bls.Verify(validator.pubkey, signing_root, signed_voluntary_exit.signature) | ||
| // # Initiate exit | ||
| // initiate_validator_exit(state, voluntary_exit.validator_index) | ||
| func verifyExitConditions(validator state.ReadOnlyValidator, currentSlot primitives.Slot, exit *ethpb.VoluntaryExit) error { | ||
| func verifyExitConditions(st state.ReadOnlyBeaconState, validator state.ReadOnlyValidator, currentSlot primitives.Slot, exit *ethpb.VoluntaryExit) error { | ||
| currentEpoch := slots.ToEpoch(currentSlot) |
There was a problem hiding this comment.
I am worried about the new state not being compatible with currentSlot here. Either the state should have state.Slot() == currentSlot in which case you can just not pass this old parameter, or you need to ensure compatibility. One may be acting on an exit for a slot with data from an old state.
There was a problem hiding this comment.
OK that is fair, I will remove the state parameter and require the fork parameter.
There was a problem hiding this comment.
Oh, actually, we must have the state. So the correct solution is to remove currentSlot and reference state.Slot() as you mentioned
potuz
approved these changes
Jul 9, 2024
saolyn
pushed a commit
that referenced
this pull request
Jul 17, 2024
* Electra: EIP-7251 Update `process_voluntary_exit` * Add unit test for VerifyExitAndSignature EIP-7251 * @potuz peer feedback
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
* add http endpoint * add tests * Gaz * Add pointers * add endpoint to test * Electra: EIP-7251 Update `process_voluntary_exit` (#14176) * Electra: EIP-7251 Update `process_voluntary_exit` * Add unit test for VerifyExitAndSignature EIP-7251 * @potuz peer feedback * Avoid Cloning When Creating a New Gossip Message (#14201) * Add Current Changes * add back check * Avoid a Panic * fix: Multiple network flags should prevent the BN to start (#14169) * Implement Initial Logic * Include check in main.go * Add tests for multiple flags * remove usage of append * remove config/features dependency * Move ValidateNetworkFlags to config/features * Nit * removed NetworkFlags from cmd * remove usage of empty string literal * add comment * add flag validation to prysctl validator-exit --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> * fix tests * Radek' review + tests * fix tests * Radek' review * forgot one * almost forgot the tests --------- Co-authored-by: Preston Van Loon <pvanloon@offchainlabs.com> Co-authored-by: Nishant Das <nishdas93@gmail.com> Co-authored-by: kira <shyampkira@gmail.com> Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com> Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Updates process_voluntary_exit to the spec changes at v1.5.0-alpha.3
Which issues(s) does this PR fix?
Other notes for review
Introduced in ethereum/consensus-specs#3668