HTTP endpoint GetIndividualVotes
#14198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saolyn
commented
Jul 10, 2024
No, we only ever remove stuff in major releases |
* Electra: EIP-7251 Update `process_voluntary_exit` * Add unit test for VerifyExitAndSignature EIP-7251 * @potuz peer feedback
* Add Current Changes * add back check * Avoid a Panic
* Implement Initial Logic * Include check in main.go * Add tests for multiple flags * remove usage of append * remove config/features dependency * Move ValidateNetworkFlags to config/features * Nit * removed NetworkFlags from cmd * remove usage of empty string literal * add comment * add flag validation to prysctl validator-exit --------- Co-authored-by: Manu NALEPA <enalepa@offchainlabs.com>
rkapka
requested changes
Jul 17, 2024
| defer span.End() | ||
|
|
||
| var req structs.GetIndividualVotesRequest | ||
| if r.Body != http.NoBody { |
There was a problem hiding this comment.
- You made the endpoint a GET, which doesn't have a body in the request. We can either put the epoch, public keys and indices in query params or make the endpoint a POST. Given that the length of a query string can be limited by some servers, the latter is a much better option.
- What if there is no body? The function will panic when reading
req.Epoch. I see we have the same pattern inGetValidatorPerformance, but this is a bug. We should return a BadRequest error in this case. What we usually do:
err = json.NewDecoder(r.Body).Decode(&req)
switch {
case errors.Is(err, io.EOF):
httputil.HandleError(w, "No data submitted", http.StatusBadRequest)
return
case err != nil:
httputil.HandleError(w, "Could not decode request body: "+err.Error(), http.StatusBadRequest)
return
}
saolyn
force-pushed
the
get-individual-votes-http
branch
from
b893d07 to
25e517a
Compare
rkapka
reviewed
Jul 19, 2024
rkapka
reviewed
Jul 19, 2024
rkapka
reviewed
Jul 19, 2024
rkapka
reviewed
Jul 19, 2024
rkapka
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This PR adds the HTTP endpoint for
GetIndividualVotesOther notes for review