Increase buffer size of usb util game name

[KrahJohlito]

Pull Request checklist

Note: these are not necessarily requirements

• I reformatted the code with clang-format
• I checked to make sure my submission worked
• I am the author of submission or have permission from the original author
• Requires update of the PS2SDK
• Requires update of the gsKit
• Others (please specify below)

Pull Request description

[AKuHAK]

That was easy :)

[AKuHAK]

BTW does it handle startup properly when startup is maximum size?
as
memcpy(g->startup, &GameEntry.startup[3], GAME_STARTUP_MAX);
maybe startup also can be synced with
char startup[GAME_STARTUP_MAX + 3];
I am not sure if buffer is enough for startup too.

[KrahJohlito]

I’m not familiar with the format I’ve only used ISO’s but if it’s the same ie SLUS_123.45 then 15 is plenty but it’s still better to have them all unified..

I think it’s just different contributors with different coding styles because GAME_STARTUP_MAX seems to include null where as the others don’t.. I prefer the +1 method personally cause it’s easy to look and see that’s for null.

Only reason the name was bugged for so long is because no one reported it so no one checked it.

[KrahJohlito]

Lol! No one tested before merge? I said I hadn’t tested it.. start up and name is messed up, strange.. anyway if it is also a USB util side issue there may be no choice but to revert and just keep the character limit at 31 as it would need to be updated there also.. maybe I’ll try contact the developer and look into fixing it both sides later on.. for now probably just revert @AKuHAK I’m on phone as usual so can’t do much at the moment.

[AKuHAK]

@KrahJohlito the funniest thing is that report was false - I just tested 32 character long games with the previous beta and everything was fine.

[AKuHAK]

Anyway I am working on some ul.cfg improvements, will fix it as well.

[KrahJohlito]

Wow that’s… terrible, ok sounds good thanks @AKuHAK!

[blckbearx]

@KrahJohlito the funniest thing is that report was false - I just tested 32 character long games with the previous beta and everything was fine.

So it works for you with the bigger buffer size? I'll try your CI builds and see, but in my case building locally leads to that issue with the increased buffer whereas building OPL without that commit works completely fine. Will edit this comment after testing.

Edit: or you mean a previous report and not mine, meaning the change was pointless? Kinda confused rn but I'm gonna test anyways just to be sure lol

Edit 2: tested your latest CI build, same issue as with my build, USB Util games still broken. The CI build previous to the commit works completely fine.

[KrahJohlito]

Edit: or you mean a previous report and not mine, meaning the change was pointless? Kinda confused rn but I'm gonna test anyways just to be sure lol

There was a report on discord that usb util games with 32 characters was broken and need to be 31 or less hence the change, however it was working fine with 32 characters so the change was pointless to begin with.

[AKuHAK]

@KrahJohlito this function is failing when gamename = 32

Open-PS2-Loader/src/system.c

Lines 272 to 295 in 955c98d

	unsigned int USBA_crc32(const char *string)
	{
	int crc, table, count, byte;
	for (table = 0; table < 256; table++) {
	crc = table << 24;
	for (count = 8; count > 0; count--) {
	if (crc < 0)
	crc = crc << 1;
	else
	crc = (crc << 1) ^ 0x04C11DB7;
	}
	crctab[255 - table] = crc;
	}
	do {
	byte = string[count++];
	crc = crctab[byte ^ ((crc >> 24) & 0xFF)] ^ ((crc << 8) & 0xFFFFFF00);
	} while (string[count - 1] != 0);
	return crc;
	}

Ps2esdl has workaround:

} while ((string[count - 1] != 0) && (count <= 32));

will try it - maybe it helps

[AKuHAK]

No, this function is correct - tested with the previous beta - didn't found any issues with 32 chars - game can be launched just fine without any problems.