-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MapKnitter Lite: fetch images from Internet Archive #998
Comments
Uploading isn't so bad; i named this one |
Just as a proof of concept, I found that static copies of MapKnitter.org in the internet archive are mostly functional: https://web.archive.org/web/20220726175945/https://mapknitter.org/maps/ceres--2/edit Pretty encouraging actually! I even tried selecting the images and generating an export, but unfortunately the export URL is also rewritten to be an archived page: https://web.archive.org/web/20211003004105/http://export.mapknitter.org/export If we could get it to generate an external request, people could still work on old MapKnitter pages, and export what they do, interesting! They wouldn't save online though. Maybe a more useful thing would be that we might think about how to accept JSON files in the format which MapKnitter serves them. Those are still backed up on the Internet Archive, so we could continue using them: https://web.archive.org/web/20220726175911/https://mapknitter.org/maps/ceres--2/warpables.json [
{"id":306187,"parent_id":null,"image_content_type":"image/jpeg","image_file_name":"DJI_1207.JPG","thumbnail":null,"image_file_size":8148349,"width":3968,"height":2976,"created_at":"2019-02-22T05:56:05.000Z","updated_at":"2019-02-27T23:13:21.000Z","map_id":13015,"nodes":[
{"id":2593754,"color":"black","author":"anonymous","lat":"-37.7664063648","lon":"144.9828654528","way_id":0,"order":0,"created_at":"2019-02-27T23:13:20.000Z","updated_at":"2019-02-27T23:13:20.000Z","name":"","description":"","map_id":0,"way_order":0,"body":null},
{"id":2593755,"color":"black","author":"anonymous","lat":"-37.7650239004","lon":"144.9831980467","way_id":0,"order":0,"created_at":"2019-02-27T23:13:20.000Z","updated_at":"2019-02-27T23:13:20.000Z","name":"","description":"","map_id":0,"way_order":0,"body":null},
{"id":2593756,"color":"black","author":"anonymous","lat":"-37.7652020107","lon":"144.9844533205","way_id":0,"order":0,"created_at":"2019-02-27T23:13:20.000Z","updated_at":"2019-02-27T23:13:20.000Z","name":"","description":"","map_id":0,"way_order":0,"body":null},
{"id":2593757,"color":"black","author":"anonymous","lat":"-37.7665844718","lon":"144.9841207266","way_id":0,"order":0,"created_at":"2019-02-27T23:13:20.000Z","updated_at":"2019-02-27T23:13:20.000Z","name":"","description":"","map_id":0,"way_order":0,"body":null}
],"locked":false,"deleted":false,"history":"","cm_per_pixel":4.99408,"src":"https://web.archive.org/web/20220726175911/https://s3.amazonaws.com/grassrootsmapping/warpables/306187/DJI_1207.JPG","srcmedium":"https://web.archive.org/web/20220726175911/https://s3.amazonaws.com/grassrootsmapping/warpables/306187/DJI_1207_medium.JPG"}
...
] Not all of those attributes are needed for exporting; in fact, just the https://github.com/publiclab/image-sequencer-app#usage Name and description could be nice too, but optional. |
I want to contribute to this |
I'd like to work on the drag image onto page to add feature @jywarren |
Hi @Dhei-vid - thank you, i do have a worry about that. Generally we are aiming for a system where you can download a 'saved' version of the map. But if we allow people to drag an image in, that image won't be readable by anyone else (since there is no server-side file storage to keep the image, it's just displayed locally to the person who dragged it, nobody else). So if we allow people to mix in locally dragged images, it could break share-ability of maps. I'm not sure what the solution is. I think it's complex and needs an issue to itself to discuss. Can you open one like "discuss design of dragged-on local images for MapKnitter Lite" and we can work through the questions there? For example, we could just warn people that some images won't be save-able. Or we could not allow dragging images, but prompt people to add the images to an Internet Archive collection. Maybe there are other possibilities too. Let's discuss in a new issue! |
Okay @jywarren |
@jywarren please can i be assigned this issue |
@jywarren please can I be assigned an issue |
This is for an idea for a static-served MapKnitter Lite.
Sketches of how this could look: https://docs.google.com/presentation/d/1kFXK0f3h2IsA2lml9L2s_REXm5p1ZGAVqfKUb9H_8Eo/edit?usp=sharing
N.B: To use MapKnitter Lite successfully, users must first upload their images to the Internet Archive and get a unique identifier or URL (for their image collection)
Guide to uploading images on Internet Archive: https://help.archive.org/help/uploading-a-basic-guide/
How to make a map:
Smaller issues
image.width
to confirm it's finished loading (i think this is the right shortcut to check image load completion?) Added spining icon forplace on map
button #1169Ways to save the map:
Bonus/stretch:
Code to fetch a gallery (CORS is now enabled for IA images):
This idea was explored in our GSoC ideas list here: https://publiclab.org/wiki/gsoc-ideas#MapKnitter+Local with the extra ideas:
Later projects/stretch goals
Something to bear in mind if you all make a lot of progress and are looking for things: #474 this issue gets at the relatively complicated external map exporter service, and it's not very well documented. If we could document it better that might go hand in hand with the local full-res map exporting mentioned above. -- @jywarren
The text was updated successfully, but these errors were encountered: