Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag n drop feature #1293

Merged
merged 1 commit into from
Dec 14, 2022
Merged

drag n drop feature #1293

merged 1 commit into from
Dec 14, 2022

Conversation

7malikk
Copy link
Collaborator

@7malikk 7malikk commented Dec 14, 2022

Fixes #998

Built on #1236 by @AndroGenius-codes

Made some improvements to the flow based on the discussions in #1236

local.html UI

localHtml

archive.html UI

localHtml-2

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in a uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

@7malikk
Copy link
Collaborator Author

7malikk commented Dec 14, 2022

Hello @jywarren, I finished this up, any pointers?

@cesswairimu Thanks for the pointer concerning numerous commits, it does look clean 😄

@segun-codes
Copy link
Collaborator

Hello @jywarren, I finished this up, any pointers?

@cesswairimu Thanks for the pointer concerning numerous commits, it does look clean 😄

@7malikk, great work!

@7malikk
Copy link
Collaborator Author

7malikk commented Dec 14, 2022

Thanks @segun-codes!!

@jywarren
Copy link
Member

Hi, this looks really good! What do you think of possibly combining the "drag" message and the link to the archive.html message into a single box? And, should people be able to minimize that box? (these could also be done in a subsequent PR as well, if you'd like to merge this now, since functionally it looks great)

@7malikk
Copy link
Collaborator Author

7malikk commented Dec 14, 2022

Hi, this looks really good! What do you think of possibly combining the "drag" message and the link to the archive.html message into a single box? And, should people be able to minimize that box? (these could also be done in a subsequent PR as well, if you'd like to merge this now, since functionally it looks great)

I had the same thought, the "drag" text just floating there and the length of the box length was unsettling.
I will address both in a subsequent PR, while this one is merged @jywarren
Thank you!

@jywarren jywarren merged commit 208ed4c into publiclab:main Dec 14, 2022
@jywarren
Copy link
Member

Sounds great, thanks!!

@7malikk 7malikk mentioned this pull request Dec 14, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MapKnitter Lite: fetch images from Internet Archive
3 participants