detect key from longer URL

[vanithaak]

Fixes #998 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updates
• @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

GIF

MapKnitter.Lite.-.Google.Chrome.2022-10-21.16-45-53.1.mp4

[gitpod-io]

[vanithaak]

@jywarren please review my pr, Thanks!!

[jywarren]

Hi, thanks for taking this up! However I think it needs a little more detail in the original problem statement. What I was thinking was, people may input either a full URL like https://archive.org/details/texas-barnraising, or they might put just the key like texas-barnraising -- they might even put just archive.org/details/texas-barnraising? Could we make a function which would output texas-barnraising in any of these three cases, or any other combinations you can think of?

I hope that helps! You've made a good start here!

[vanithaak]

@TildaDares , @jywarren please review my pr, Thanks!

[jywarren]

This is looking good! I'd like to test it out a bit. But can you put it within its own named function, like function showImages(getUrl) { below? Maybe it could be named function extractKey()?

[vanithaak]

@jywarren , please review my pr

[vanithaak]

@jywarren , please review my pr. Thanks!

[jywarren]

Oops, sorry, i accidentally pressed the wrong button!

Very nice. I tested it, and several variations worked fine. However, I noticed that entering this did not work:

http://archive.org/details/texas-barnraising

I'm going to merge this, but maybe we can add an additional line to add the s if it's just http://?

[jywarren]

I'm going to merge this, but maybe we can add an additional line to add the s if it's just http://?

Actually maybe that could be a first-timers-only issue?

[jywarren]

Nicely done!!!

[vanithaak]

I'm going to merge this, but maybe we can add an additional line to add the s if it's just http://?

Actually maybe that could be a first-timers-only issue?

Hi @jywarren, would you like me to make a first-timer-issue?

[segun-codes]

I'm going to merge this, but maybe we can add an additional line to add the s if it's just http://?

Actually maybe that could be a first-timers-only issue?

Hi @jywarren, would you like me to make a first-timer-issue?

Hi @vanithaak, since in the conversation here https://github.com/publiclab/Leaflet.DistortableImage/pull/1232 @jywarren suggested I could fix the http/https issue, so I would simply attend to it and that will be it.

[vanithaak]

Hi @vanithaak, since in the conversation here https://github.com/publiclab/Leaflet.DistortableImage/pull/1232 @jywarren suggested I could fix the http/https issue, so I would simply attend to it and that will be it.

Hey ! sounds good! I'll create an issue for you to contribute!