Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoBar toggle #1296

Merged
merged 2 commits into from
Dec 16, 2022
Merged

infoBar toggle #1296

merged 2 commits into from
Dec 16, 2022

Conversation

7malikk
Copy link
Collaborator

@7malikk 7malikk commented Dec 14, 2022

Based on the review comment here: #1293 (comment)
I included a toggle open and close button, with all functionality retained

Here is the UI:

infoBar

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in a uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

@7malikk
Copy link
Collaborator Author

7malikk commented Dec 14, 2022

@jywarren Hello, here is the implementation based on what we discussed in #1293

@jywarren
Copy link
Member

This looks really nice. Maybe I could suggest the icon could remain stuck to the right-side? Sorry for such a small request but I think it makes sense and the menu icon would read more clearly if it remained on the wall. Thank you!

@7malikk
Copy link
Collaborator Author

7malikk commented Dec 15, 2022

This looks really nice. Maybe I could suggest the icon could remain stuck to the right-side? Sorry for such a small request but I think it makes sense and the menu icon would read more clearly if it remained on the wall. Thank you!

@jywarren Alright then, will do. Thank you!

@7malikk 7malikk merged commit 2d2aad1 into publiclab:main Dec 16, 2022
@7malikk 7malikk mentioned this pull request Dec 16, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants