Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem with meta-modules #1239

Closed
keshav234156 opened this issue Aug 29, 2019 · 10 comments · Fixed by #1426 or #1432
Closed

problem with meta-modules #1239

keshav234156 opened this issue Aug 29, 2019 · 10 comments · Fixed by #1426 or #1432

Comments

@keshav234156
Copy link
Member

There are many errors occuring while using meta-module(colorbar and ndvi-colormap).
Steps to reproduce
1 .chose nvdi-colormap(or colorbar)
2.then chose any other module and change the value that is not the default value
it would now change image produced by the above mentioned module as well .

Screencastfrom29-08-19095222PMIS


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@welcome
Copy link

welcome bot commented Aug 29, 2019

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

@keshav234156
Copy link
Member Author

@jywarren @harshkhandeparkar please have a look

@harshkhandeparkar
Copy link
Member

I had a look at this already. Would like to solve this one? Do you have any idea why this is happening?

@ataata107
Copy link

@harshkhandeparkar Is this issue still up as I would like to work on this.

@rishabhshuklax
Copy link
Member

Hi @ataata107 I'm currently working on this. But would love your inputs on this.

@ataata107
Copy link

Ok Got It.
It is the scope error. In createMetaModule,js the following line
var internalSequencer = ImageSequencer({ inBrowser: false, ui: false });

This line needs to go inside function draw(input, callback) { in createMetaModule,js

Could you help me as to know how to claim a issue as I didn't know you had already claimed this one.

@rishabhshuklax
Copy link
Member

It is the scope error. In createMetaModule,js the following line
var internalSequencer = ImageSequencer({ inBrowser: false, ui: false });

This line needs to go inside function draw(input, callback) { in createMetaModule,js

I did that yesterday but it didn't work, but it looks like i forgot to clear the cache, silly me 😵

Could you help me as to know how to claim a issue as I didn't know you had already claimed this one.

You should just comment on the issue to claim it, I did the mistake of not commeting it, sorry.

You can help on # 1211 I tried but had no luck with this. Thanks!

@rishabhshuklax
Copy link
Member

Ok so while working on #1431 I found out that this issue was not resolved and for same reason #1418 colorbar is also not working, I think I know why this might be happening I'll make a new PR for it ASAP!

@keshav234156
Copy link
Member Author

@blurry-x-face This has been fixed . The main issue was that the above step was getting different but it not the case after you have made the changes in #1426

@rishabhshuklax
Copy link
Member

rishabhshuklax commented Jan 6, 2020

Ohh yes you're right this was a different issue, but the problem was same both of the variable were out of scope, So should I create a new issue for this or maybe you could just reopen this one with additional description? @keshav234156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants