Fix Meta modules and add inputs to ndvi-colormap #1432
Conversation
rishabhshuklax
changed the title
|
@publiclab/is-reviewers @jywarren @keshav234156 please review this again, In my last PR whole bug was not resolved. |
Codecov Report
@@ Coverage Diff @@
## main #1432 +/- ##
=====================================
Coverage 66.4% 66.4%
=====================================
Files 125 125
Lines 2581 2581
Branches 410 410
=====================================
Hits 1714 1714
Misses 867 867
|
| @@ -1,6 +1,24 @@ | |||
| { | |||
| "name": "ndvi-colormap", | |||
| "description": "Sequentially Applies NDVI and Colormap steps", | |||
| "inputs": {}, | |||
| "inputs": { | |||
There was a problem hiding this comment.
Wow. That's a big fix. Very important.
| // use this to set defaults for internal steps | ||
| // and to expose internal settings as external meta-module parameters; | ||
| // it must return a steps object | ||
| var steps = mapFunction(options); |
There was a problem hiding this comment.
Hi @tech4GT can you check this change of scope? Thank you!
There was a problem hiding this comment.
Linking to explanation: #1239 (comment)
|
This is looking great; i asked @tech4GT to review as he most recently worked on these files. Would it be possible to confirm this change with a test? https://github.com/publiclab/image-sequencer/blob/main/test/core/modules/colormap.js |
|
@jywarren after #1239 the problem that still remained was that when option where changes is still processed the image with original option. This thing we are currently not testing that why they always passed. To test this we need to change https://github.com/publiclab/image-sequencer/blob/main/test/core/templates/module-test.js and all test modules using it .It would be a big change |
|
Yes, this is the reason why the current tests weren't able to detect it and we can make those changes in a new PR and I will be happy to make these changes but lets merge this one for now. |
|
OK, that sounds good. Just checking! Thank you!!! |
Fixes #1239 ,Fixes #1418 , Fixes #1431
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test@publiclab/is-reviewersfor help, in a comment belowBelow is the working GIFS
