-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix meta module bug #1426
Fix meta module bug #1426
Conversation
@publiclab/is-reviewers |
Codecov Report
@@ Coverage Diff @@
## main #1426 +/- ##
==========================================
- Coverage 66.36% 66.35% -0.02%
==========================================
Files 125 125
Lines 2572 2574 +2
Branches 406 406
==========================================
+ Hits 1707 1708 +1
- Misses 865 866 +1
|
@blurry-x-face can you please upload a gif |
Great I think this is good to go. |
Nicely Done!!! |
Awesome. Thanks! And hi, @Divy123 !!! |
Hi @jywarren !! How are you? |
Great!!! So good to hear from you. I got your email, i'm just behind a bit as usual 😅 |
No probs !! So good to be back here. And definitely missing our weekly calls. |
Fixes #1239
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!