Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out longer functions into sub source files and require in #26

Closed
jywarren opened this issue Jun 16, 2017 · 5 comments
Closed

Break out longer functions into sub source files and require in #26

jywarren opened this issue Jun 16, 2017 · 5 comments
Assignees

Comments

@jywarren
Copy link
Member

If it's possible, can you check if you can break out any of your longer functions into sub files? If you need shared scope, maybe you'll have to pass them in via the function parameters, so they'll be less inter-referential.

But this will make your code into smaller, more independent and easier (one thing per function) parts. So I think it's worth it in some cases!

@ccpandhare
Copy link
Collaborator

Yes, I do agree with this. I will see to it.

@ccpandhare
Copy link
Collaborator

Although #28 does not do exactly this, I believe it addresses the issue partially... What do you think @jywarren ?

@ccpandhare
Copy link
Collaborator

Now #28 Addresses this issue wholly. Is this okay?

@jywarren
Copy link
Member Author

jywarren commented Jun 26, 2017 via email

@ccpandhare
Copy link
Collaborator

Closing this issue then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants