forked from jywarren/image-sequencer
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break out longer functions into sub source files and require in #26
Labels
Comments
Yes, I do agree with this. I will see to it. |
Now #28 Addresses this issue wholly. Is this okay? |
yep, looks great!
…On Mon, Jun 26, 2017 at 3:05 PM, Chinmay Pandhare ***@***.***> wrote:
Now #28 <#28> Addresses
this issue wholly. Is this okay?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJwQQxDCte39OxtsskxfzXKhmiSRlks5sIAEFgaJpZM4N85Tv>
.
|
Closing this issue then |
This was referenced Jan 4, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If it's possible, can you check if you can break out any of your longer functions into sub files? If you need shared scope, maybe you'll have to pass them in via the function parameters, so they'll be less inter-referential.
But this will make your code into smaller, more independent and easier (one thing per function) parts. So I think it's worth it in some cases!
The text was updated successfully, but these errors were encountered: