use require() in index.js to source from /src/cli/

[jywarren]

The index.js file in the root directory runs the CLI interface. But the CLI code is a bit long now, and could be easier to read. Let's break it up into a few different files kept in /src/cli/ and use require() to access them from index.js. This will result in cleaner and easier to read code.

Personally I like this type of task! It can be pretty fun to tidy things up. The CLI tests should help us ensure this is done properly, too. We'd love some help!

[gitmate]

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are #26 (Break out longer functions into sub source files and require in), and #150 (Using GitMate).

[gitmate]

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are #26 (Break out longer functions into sub source files and require in), and #150 (Using GitMate).

[vibhorgupta-gh]

@jywarren @tech4GT PR #665 addresses this.

The validateSteps and validateConfig methods were moved to CliUtils.js where the makedir method, also used in CLI code, is written.
src/cli/ contains files according to the commands that the user will give. --save-sequence has its own file, --install-module has its own file and the code handling the process of generating module outputs is has its separate file. Everything is required in index.js. Thoughts?

[vibhorgupta-gh]

@jywarren using strict mode is always good, as you mentioned in the PR, let's do it!
However, is the let based error affecting this PR too? I don't think it is...

[vibhorgupta-gh]

@jywarren also, if we'd like to fix the let issue in Travis, let's replace it with var for now, because using the strict mode requires a lot of other things to be taken care of, which I think is best to pursue in a separate issue. A new issue could be created dedicated to introducing the strict scope in js files. For simplicity though, I'd suggest merging #665 without a major overhaul

[jywarren]

Oh ok great! On Jan 12, 2019 6:04 PM, "Vibhor Gupta" <notifications@github.com> wrote: @jywarren <https://github.com/jywarren> also, if we'd like to fix the let issue in Travis, let's replace it with var for now, because using the strict mode requires a lot of other things to be taken care of, which I think is best to pursue in a separate issue. A new issue could be created dedicated to introducing the strict scope in js files. For simplicity though, I'd suggest merging #665 <#665> without a major overhaul — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#658 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ8xU1vwaZO1xszEBhcoHucqHFDIUks5vCmnRgaJpZM4Z8euX> .

[vibhorgupta-gh]

Shall I then? Replace the let with var?

[jywarren]

yes, let's do that. Thanks. On Jan 12, 2019 6:18 PM, "Vibhor Gupta" <notifications@github.com> wrote: Shall I then? Replace the let with var? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#658 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ6x9Fn75MUWYGAqH-1HriH0-I7tAks5vCm0bgaJpZM4Z8euX> .

[vibhorgupta-gh]

@jywarren is #665 mergeable?