forked from jywarren/image-sequencer
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prior steps need not re-run when a new module is added or deleted #269
Comments
@jywarren Actually I also noticed this while working on the getStepApi, but this would call for some major changes in demo architecture or even in the architecture of the sequencer itself, I would suggest we keep this long term, what say? |
tech4GT
added a commit
to tech4GT/image-sequencer
that referenced
this issue
Jun 1, 2018
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
Merged
ghost
assigned tech4GT
Jun 1, 2018
ghost
added
the
in-progress
label
Jun 1, 2018
jywarren
pushed a commit
that referenced
this issue
Jun 8, 2018
* fixes #269 Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * update demo Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * refactor and comments Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * update readme Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * updated and refactored Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * update readme Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * trying to fix tests Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * update documentation Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * update to config.mode = test Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * finaly everything works Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * 1.8.0 * update test Signed-off-by: tech4GT <varun.gupta1798@gmail.com> * add test for run Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
ghost
removed
the
in-progress
label
Jun 8, 2018
This was referenced Oct 1, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the demo, I see the entire sequence being re-triggered when a module is added or deleted.
We should only have to run the final new step, if a new one is added, and if one is deleted, only the steps after it. Let's look at the logic and if we need to make
run()
accept a parameter likesequencer.run(startIndex)
we can do that.The text was updated successfully, but these errors were encountered: