add fisheyegl module

[jywarren]

Hi, @ccpandhare - whats the latest?

I wanted to add this as a feature request down the line -- it's a good one to try to develop a test for:

https://github.com/jywarren/fisheyegl

could be a great module. I want to suggest a test that takes a checkerboard image and corrects fisheye, then diff-compares it with a correct checkerboard.

[ccpandhare]

Currently, I am designing tests for the core functionality.

Sure, I will add this module in.

[ccpandhare]

I had a look at the code. The module works on canvasses so I'll have to figure out how to make things work for Node.js and that may take some time...

[jywarren]

Low priority!!

…

On Jun 23, 2017 2:51 AM, "Chinmay Pandhare" ***@***.***> wrote: I had a look at the code. The module works on canvasses so I'll have to figure out how to make things work for Node.js and that may take some time... — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#27 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ7LVFDWWyLBy1V3x9_Uo-LJu_aAUks5sG2CLgaJpZM4OC8rl> .

[ccpandhare]

Ohh okay. Also, I am working on a unified input parser.

[jywarren]

I think it should be OK to have some modules which are marked as working only in the browser. In theory, we could shim this so it'd boot up a phantomjs instance, too, but we can think about that later.

I mentioned some interest from NASA folks and I think this may be a good project that they could use. I'd like to get a demo running with a crop module and then pass the output to this lensDistortion module, and have a web-based demo of it -- what do you think? It'd be a great proof of your work to date, even if it doesn't yet work in Node.

[ccpandhare]

Okay! Wow!
Sounds great!!

[ccpandhare]

I think I can work on that demo now.

[jywarren]

Oh great!

…

On Jul 8, 2017 8:54 AM, "Chinmay Pandhare" ***@***.***> wrote: I think I can work on that demo now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#27 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJwCNvjG9jx05t7R1VbT6SxkjICRtks5sL3wPgaJpZM4OC8rl> .

[ccpandhare]

I have ported the Latest FisheyeGL version from jywarren/fisheyegl to ImageSequencer.
I am adding it to documentation and will create a Pull Request soon!

[jywarren]

Will we need to adjust the module to point at the fisheyegl mom package?

[ccpandhare]

Well once the README.md of jywarren/fisheyegl is complete and is published to npm, we can just require in fisheyegl from npm and use it directly. I shall complete that immediately.

[jywarren]

fisheyegl v0.1.0 now published :-)

[ccpandhare]

Okay thanks!

[ccpandhare]

I think it hasn't updated yet.
npm/fisheyegl still shows the old README.md and

npm i fisheyegl

is still serving the old files

[jywarren]

hmm, i didn't include the README but the files should be new. i'll issue v0.1.1 to be sure.

…

On Wed, Jul 26, 2017 at 10:18 PM, Chinmay Pandhare ***@***.*** > wrote: I think it hasn't updated yet. npm/fisheyegl <https://www.npmjs.com/package/fisheyegl> still shows the old README.md and npm i fisheyegl is still serving the old files — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#27 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJzT_yw1MqfvPrRheu8qSNVEo3ZUUks5sR58hgaJpZM4OC8rl> .

[ccpandhare]

Now it works fine, thanks!

[jywarren]

great.